Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked out of feed edit page when using '/' in name #65

Open
morganridel opened this issue Dec 18, 2023 · 1 comment
Open

Locked out of feed edit page when using '/' in name #65

morganridel opened this issue Dec 18, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@morganridel
Copy link

Hello, nice project!

I'm trying it out for myself and it seems that using a '/' character in a feed name prevent access to any url using the feed name. I know bugs should be expected, I'm sharing it just in case.

image

STRs:

  • Add the feed https://www.reddit.com/r/selfhosted/top.rss with name /r/selfhosted
  • Get a 404 on the resulting /feeds//r/selfhosted/entries page
  • Can't access or delete the feed afterwards

I had to manually edit the sqlite database to fix this.

I guess you could disallow forward slashes or maybe url-encode them?

@facundoolano facundoolano added the bug Something isn't working label Dec 18, 2023
@facundoolano
Copy link
Owner

Thanks for reporting.

I guess you could disallow forward slashes or maybe url-encode them?

Yes I should do one of things things. There's the alternative of not using names in the urls, but at least for the filtering I think it's desirable to have it displayed in the url (arguably the same could be done by using id + slug).

A related set of bugs happens with using spaces in the names, that should also be handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants