-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker packages setup #106
Conversation
facundoolano
commented
Jul 14, 2024
- Tweaks the github action and dockerfile definitions to build and push to github packages when a version is tagged.
- Adds some usage instructions in the readme to run both in development and production mode
@julienma following up here on the PR you've sent. I still need to fill in instructions so it's more obvious how to quickly try the app locally with the default feeds. I could use some context regarding how do you plan to run this, to make sure the config isn't over complicated and to document in the README (eg. will you run with authentication enabled? is it reasonable to manually issue commands to setup the secret key of the app?) cc @raynix since you've sent a similar PR. |
@facundoolano nice! Your instructions are pretty clear to me. For context, I'm using docker compose files. Here's what I did:
Anyway, if you want to give an example docker compose file in your README, here's my minimal version: "3.8"
services:
feedi:
restart: unless-stopped
image: ghcr.io/facundoolano/feedi:latest
environment:
FLASK_ENV: production
ports:
- 9988:9988
volumes:
- ./instance:/app/instance
- ./config/production.py:/app/feedi/config/production.py |
Yes, this setup is overly complicated, I've been thinking how to improve it. My original intention was to make sure you couldn't start in prod mode without explicitly setting a SECRET_KEY, that's why I made production.py a hard requirement. But I think what I'll do instead is to make production.py optional, and check explicitly for SECRET_KEY, after loading all configuration sources. |