Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/builder.md: remove BuilderByTarget references #345

Merged
merged 2 commits into from
May 23, 2024

Conversation

nnzv
Copy link
Contributor

@nnzv nnzv commented May 23, 2024

The 'Target name' subsection is old. BuilderByTarget isn't used anymore; it's now byTarget in target.go. Add a hyperlink for clarity and accessibility.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

/kind documentation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area pkg

/area docs

What this PR does / why we need it:

The commit by @FedeDP seems to have caused this 56573f4, but it appears that the documentation hasn't been updated to match the current logic of the builders.

Which issue(s) this PR fixes:

Special notes for your reviewer:

No

Does this PR introduce a user-facing change?:

No

The 'Target name' subsection is old. BuilderByTarget isn't used anymore; it's now 'byTarget' in target.go. Add a hyperlink for clarity and accessibility.

Signed-off-by: Enzo Venturi <nzventuri@proton.me>
@poiana
Copy link

poiana commented May 23, 2024

Welcome @nnzv! It looks like this is your first PR to falcosecurity/driverkit 🎉

@poiana poiana added the size/XS label May 23, 2024
@nnzv
Copy link
Contributor Author

nnzv commented May 23, 2024

/assign FedeDP

@FedeDP
Copy link
Contributor

FedeDP commented May 23, 2024

Hi!
Thanks for this PR! It LGTM!
The commit is missing the dco though, can you fix it? https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#developer-certificate-of-origin

docs/builder.md: remove BuilderByTarget references

Signed-off-by: Enzo Venturi <nzventuri@proton.me>
@nnzv
Copy link
Contributor Author

nnzv commented May 23, 2024

The commit is missing the dco though, can you fix it? https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#developer-certificate-of-origin

Thanks for pointing that out. Didn't notice. Fixed now.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label May 23, 2024
@poiana
Copy link

poiana commented May 23, 2024

LGTM label has been added.

Git tree hash: 9db885e3ab116fab373b9f17d51bc198be254f95

@poiana
Copy link

poiana commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, nnzv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 508fb74 into falcosecurity:master May 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants