Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/builder.md: remove BuilderByTarget references #345

Merged
merged 2 commits into from
May 23, 2024
Merged

docs/builder.md: remove BuilderByTarget references #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df4c878
docs/builder.md: remove BuilderByTarget references
nnzv May 23, 2024
805bc4b
Merge pull request #1 from nnzv/nnzv-patch-1
nnzv May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/builder.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Your builder will need a constant for the target it implements. Usually that con
can just be the ID of the distribution you are implementing, as taken reading `/etc/os-release` file.
A builder can implement more than one target at time. For example, the minikube builder is just a vanilla one.

Once you have the constant, you will need to add it to the `BuilderByTarget` map.
Once you have the constant, you will need to add it to the [byTarget](https://github.com/falcosecurity/driverkit/blob/master/pkg/driverbuilder/builder/target.go) map.
Open your file and you will need to add something like this:

```go
Expand All @@ -48,7 +48,7 @@ type archLinux struct {
}

func init() {
BuilderByTarget[TargetTypeArchLinux] = &archLinux{}
byTarget[TargetTypeArchLinux] = &archLinux{}
}
```

Expand Down Expand Up @@ -145,4 +145,4 @@ can also support collecting the new builders kernel versions and header package
for the new builder are automatically built by [test-infra](https://github.com/falcosecurity/test-infra). If required, add a feature request
for support for the new builder on the kernel-crawler repository.

> **NOTE**: be sure that the crawler you are going to add is interesting for the community as a whole.
> **NOTE**: be sure that the crawler you are going to add is interesting for the community as a whole.
Loading