fix panic when an output target is wrong

Signed-off-by: Thomas Labarussias <issif+github@gadz.org>
falcosecurity · Sep 4, 2024 · 38d9616 · 38d9616
1 parent 9ab77ca
commit 38d9616
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/cmd/rules.go b/cmd/rules.go
@@ -69,14 +69,14 @@ var rulesChecksCmd = &cobra.Command{
 							if output == nil {
 								utils.PrintLog("error", utils.LogLine{Error: "unknown target", Rule: i.GetName(), Action: j.GetName(), OutputTarget: o.GetTarget(), Message: "rules"})
 								valid = false
-							}
-							if len(o.Parameters) == 0 {
+							} else if len(o.Parameters) == 0 {
 								utils.PrintLog("error", utils.LogLine{Error: "missing parameters for the output", Rule: i.GetName(), Action: j.GetName(), OutputTarget: o.GetTarget(), Message: "rules"})
 								valid = false
-							}
-							if err := output.CheckParameters(o); err != nil {
-								utils.PrintLog("error", utils.LogLine{Error: err.Error(), Rule: i.GetName(), Action: j.GetName(), OutputTarget: o.GetTarget(), Message: "rules"})
-								valid = false
+							} else {
+								if err := output.CheckParameters(o); err != nil {
+									utils.PrintLog("error", utils.LogLine{Error: err.Error(), Rule: i.GetName(), Action: j.GetName(), OutputTarget: o.GetTarget(), Message: "rules"})
+									valid = false
+								}
 							}
 						}
 					}

diff --git a/cmd/server.go b/cmd/server.go
@@ -71,14 +71,14 @@ var serverCmd = &cobra.Command{
 							if output == nil {
 								utils.PrintLog("error", utils.LogLine{Error: "unknown target", Rule: i.GetName(), Action: j.GetName(), OutputTarget: o.GetTarget(), Message: "rules"})
 								valid = false
-							}
-							if len(o.Parameters) == 0 {
+							} else if len(o.Parameters) == 0 {
 								utils.PrintLog("error", utils.LogLine{Error: "missing parameters for the output", Rule: i.GetName(), Action: j.GetName(), OutputTarget: o.GetTarget(), Message: "rules"})
 								valid = false
-							}
-							if err := output.CheckParameters(o); err != nil {
-								utils.PrintLog("error", utils.LogLine{Error: err.Error(), Rule: i.GetName(), Action: j.GetName(), OutputTarget: o.GetTarget(), Message: "rules"})
-								valid = false
+							} else {
+								if err := output.CheckParameters(o); err != nil {
+									utils.PrintLog("error", utils.LogLine{Error: err.Error(), Rule: i.GetName(), Action: j.GetName(), OutputTarget: o.GetTarget(), Message: "rules"})
+									valid = false
+								}
 							}
 						}
 					}