attempt to fix the error when we update the network policy

Signed-off-by: Thomas Labarussias <issif+github@gadz.org>
falcosecurity · Feb 15, 2024 · ddfff20 · ddfff20
1 parent ec58581
commit ddfff20
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/actionners/calico/networkpolicy/networkpolicy.go b/actionners/calico/networkpolicy/networkpolicy.go
@@ -143,12 +143,11 @@ func Action(action *rules.Action, event *events.Event) (utils.LogLine, error) {
 		payload.Spec.Egress = []networkingv3.Rule{*denyRule}
 		payload.Spec.Egress = append(payload.Spec.Egress, *allowRule)
 		_, err = calicoClient.ProjectcalicoV3().NetworkPolicies(namespace).Create(context.Background(), &payload, metav1.CreateOptions{})
+		if errorsv1.IsAlreadyExists(err) {
+			netpol, err = calicoClient.ProjectcalicoV3().NetworkPolicies(namespace).Get(context.Background(), owner, metav1.GetOptions{}) //nolint:golint,staticcheck
+		}
 		output = fmt.Sprintf("the networkpolicy '%v' in the namespace '%v' has been created", owner, namespace)
-	}
-	if errorsv1.IsAlreadyExists(err) {
-		netpol, err = calicoClient.ProjectcalicoV3().NetworkPolicies(namespace).Get(context.Background(), owner, metav1.GetOptions{})
-	}
-	if err == nil {
+	} else if err == nil {
 		payload.ObjectMeta.ResourceVersion = netpol.ObjectMeta.ResourceVersion
 		var denyCIDR []string
 		for _, i := range netpol.Spec.Egress {