Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config.yaml): fix wrong severity levels for sinsp logger #2736

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind bug

/kind documentation

Any specific area of the project related to this PR?

What this PR does / why we need it:

This PR fixes wrong severity levels for sinsp logger in falco.yaml

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

docs(config.yaml): fix wrong severity levels for sinsp logger

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
@Andreagit97
Copy link
Member Author

/milestone 0.36.0

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 23, 2023

LGTM label has been added.

Git tree hash: 206445f4e4c9c38a1f70796cab6ca52c5979f438

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since it realigns the documentation with the actual implementations.

However, it's very confusing that the libs logger uses a different set of severity levels, whereas all other Falco options use the standard syslog severity levels.

May we fix this in libs? Or do we have a compelling reason not to do that? 🤔
cc @Andreagit97 @FedeDP

@poiana
Copy link
Contributor

poiana commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit bc12e56 into falcosecurity:master Aug 23, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants