Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake): bump libs and driver to latest master #3283

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

/area tests

What this PR does / why we need it:

Just updating libs and fix tests to catch warnings with new output messages.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@jasondellaluce
Copy link
Contributor Author

/milestone 0.39.0

@poiana poiana added this to the 0.39.0 milestone Jul 19, 2024
@poiana poiana added the size/S label Jul 19, 2024
@poiana poiana requested review from Kaizhe and leogr July 19, 2024 13:39
LucaGuerra
LucaGuerra previously approved these changes Jul 19, 2024
@poiana
Copy link
Contributor

poiana commented Jul 19, 2024

LGTM label has been added.

Git tree hash: 61dc250820589c04df0699b569d851a423f0ba96

@LucaGuerra
Copy link
Contributor

@jasondellaluce seems like this isn't building because of a missing metrics method, do you have a patch for it?

@LucaGuerra
Copy link
Contributor

falcosecurity/libs#1971

leogr
leogr previously approved these changes Jul 22, 2024
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana
Copy link
Contributor

poiana commented Jul 22, 2024

LGTM label has been added.

Git tree hash: fed86b5e1e4ed4295b6399ff14a8b9569cc84e49

@FedeDP
Copy link
Contributor

FedeDP commented Jul 30, 2024

Updated once again to bring in the changes from falcosecurity/libs#1960

@FedeDP
Copy link
Contributor

FedeDP commented Jul 30, 2024

We need to fix the windows CI that is complaining about zlib; most probably caused by this change: falcosecurity/libs#1940 or falcosecurity/libs#1899 :/

@FedeDP
Copy link
Contributor

FedeDP commented Jul 31, 2024

Incorporated the fix by @geraldcombs in the latest commit.

@FedeDP
Copy link
Contributor

FedeDP commented Jul 31, 2024

@Molter73 how is this building without your #3265 🤣

@FedeDP
Copy link
Contributor

FedeDP commented Jul 31, 2024

Failing test:

  TestFalco_Legacy_FalcoEventGenerator

    legacy_test.go:2688: 
        	Error Trace:	/home/runner/work/_actions/falcosecurity/testing/main/legacy_test.go:2688
        	Error:      	Should not be zero, but was 0
        	Test:       	TestFalco_Legacy_FalcoEventGenerator
    legacy_test.go:2691: 
        	Error Trace:	/home/runner/work/_actions/falcosecurity/testing/main/legacy_test.go:2691
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestFalco_Legacy_FalcoEventGenerator

and we also have 4 tests that are receiving heapbuffer overflow errors on x86:

        	            	==9743==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020000ed340 at pc 0x000000b0c73e bp 0x7ffda518c300 sp 0x7ffda518c2f0

@Molter73
Copy link
Contributor

@Molter73 how is this building without your #3265 🤣

I honestly have no idea, #3265 was failing to compile too, I checked.

I must have messed up a rebase or something before merging falcosecurity/libs#1920, the new_metric method is duplicated in 2 different classes. 🤦🏻‍♂️

https://github.com/falcosecurity/libs/blob/3ce0a2ddb41de2e5e446da0882f0aca836805c46/userspace/libsinsp/metrics_collector.h#L339-L350

https://github.com/falcosecurity/libs/blob/3ce0a2ddb41de2e5e446da0882f0aca836805c46/userspace/libsinsp/metrics_collector.h#L248-L259

@LucaGuerra
Copy link
Contributor

@Molter73 after falcosecurity/libs#1971 it built just fine locally for me 🤔

@Molter73
Copy link
Contributor

@Molter73 after falcosecurity/libs#1971 it built just fine locally for me 🤔

Yeah, I messed up and left in a method that I should've removed and now it's duplicated, I'll open a PR and clean it up.

I don't know if we want to rush this in though, since it's a minor cleanup, let me know what you guys think.

@FedeDP
Copy link
Contributor

FedeDP commented Jul 31, 2024

No problem @Molter73, take your time! I think it would be great to clean that up for libs 0.18.0 (by the end of august), but no hurry.

jasondellaluce and others added 5 commits August 20, 2024 16:09
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra
Copy link
Contributor

Opened an issue for the test failure: falcosecurity/libs#2018

Also, fixes some newly introduced API breaks.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor

FedeDP commented Aug 26, 2024

@FedeDP
Copy link
Contributor

FedeDP commented Aug 26, 2024

Tests passed!!! 🚀

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 26, 2024

LGTM label has been added.

Git tree hash: 6249f4fc5c369ef6bef06b92269e1d3dc05a571f

@poiana
Copy link
Contributor

poiana commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 4e45152 into master Aug 26, 2024
32 of 33 checks passed
@poiana poiana deleted the update/bump-libs-to-latest branch August 26, 2024 13:51
@LucaGuerra
Copy link
Contributor

We did it! 🚀 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants