Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(falco): allow plugin init_config map in json schema #3335

Merged

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area engine

What this PR does / why we need it:

It is possible to specify plugin init config like:

plugins:
  - name: k8saudit
    library_path: libk8saudit.so
    init_config:
      maxEventSize: 262144
      sslCertificate: /etc/falco/falco.pem

or

plugins:
  - name: k8saudit
    library_path: libk8saudit.so
    init_config: '{"maxEventSize": 262144, "sslCertificate": "/etc/falco/falco.pem"}'

But json schema didn't allow that and only accepted a string. This PR adds the map option to the schema.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(falco): allow plugin init_config map in json schema

Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra
Copy link
Contributor Author

cc @FedeDP @alacuku I would add this to 0.39.0 if you agree as Falco is currently emitting warnings on valid configs

/milestone 0.39.0

@poiana poiana added this to the 0.39.0 milestone Sep 19, 2024
@alacuku
Copy link
Member

alacuku commented Sep 19, 2024

cc @FedeDP @alacuku I would add this to 0.39.0 if you agree as Falco is currently emitting warnings on valid configs

/milestone 0.39.0

Thanks for the fix!

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

@poiana
Copy link
Contributor

poiana commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Sep 19, 2024

LGTM label has been added.

Git tree hash: 71e7c56302323e01d350946cdf3ebdb6debdabd4

@poiana poiana merged commit 50f4bc1 into falcosecurity:master Sep 20, 2024
33 of 34 checks passed
This was referenced Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants