feat(stats): add host_netinfo networking information stats family #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
size/M
release-note
and removed
do-not-merge/release-note-label-needed
labels
|
/milestone 0.39.0 |
|
@ekoops: You must be a member of the falcosecurity/falco-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your maintainers of falcosecurity/falco and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
LucaGuerra
reviewed
Sep 26, 2024
ekoops
force-pushed
the
add-host-netinfo-stats
branch
2 times, most recently
from
f4673a9
to
b3d3dc8
Compare
LucaGuerra
reviewed
Sep 26, 2024
|
I had just a couple minor comments, otherwise LGTM, thanks! |
Introduce host_netinfo stats family to hold information regarding host networking. At the moment, it only provides ipv4 and ipv6 addresses list for each interface available on the host. The naming schema for the introduced stats is falco.host_netinfo.interfaces.<ifname>.protocols.<ipv4|ipv6>.addresses. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
ekoops
force-pushed
the
add-host-netinfo-stats
branch
from
b3d3dc8
to
19385f4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: eb97145eb4d74430ac8a828e1ecd4a5f491cbb03
|
|
/milestone 0.39.0 |
|
@ekoops can you share an example output? Thanks! |
|
Yes sure! Here two |
LucaGuerra
approved these changes
Sep 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR introduces
host_netinfostats family to hold information regarding host networking. At the moment, it only provides ipv4 and ipv6 addresses lists for each interface available on the host.The naming schema for the introduced stats is
falco.host_netinfo.interfaces.<ifname>.protocols.<ipv4|ipv6>.addresses="<address_list>", whereaddress_listis a comma separated list of network addresses (e.g.:"10.0.0.1,10.0.0.2"). This schema avoids JSON parsing and is easily extensible (e.g.: we could easily introduceifindexto specify the interface index, orhw_addrto specify the mac address).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: