Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore_some_files for clang format #3351

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

Andreagit97
Copy link
Member

@Andreagit97 Andreagit97 commented Sep 30, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

This PR avoids the following error https://lists.llvm.org/pipermail/llvm-bugs/2018-May/064824.html when running clang-format on these files

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Sep 30, 2024

LGTM label has been added.

Git tree hash: 2f562fa4971d0aa2f71423ac1d7518a940a016cd

@FedeDP
Copy link
Contributor

FedeDP commented Sep 30, 2024

/milestone 0.39.0

@Andreagit97 Andreagit97 changed the title update: ignore_some_files for clang format chore: ignore_some_files for clang format Sep 30, 2024
@poiana poiana added this to the 0.39.0 milestone Sep 30, 2024
@poiana poiana merged commit 11bac9d into falcosecurity:master Sep 30, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants