Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: release 0.39.1 #3371

Merged
merged 5 commits into from
Oct 8, 2024
Merged

sync: release 0.39.1 #3371

merged 5 commits into from
Oct 8, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Oct 7, 2024

What type of PR is this?

/kind release

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

Cherry picks

Plus, it updates the changelog in a standalone commit ready to be cherry picked on master.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

FedeDP and others added 2 commits October 7, 2024 17:44
… capability.

In live mode we need to use the source_info inspectors instead of the offline inspector.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Luca Guerra <luca@guerra.sh>
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 7, 2024

/milestone 0.39.1

@poiana poiana added this to the 0.39.1 milestone Oct 7, 2024
@poiana
Copy link
Contributor

poiana commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 7, 2024

/hold
Will use this very same PR to also update the changelog.

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 8, 2024

Bumped the changelog (in its own commit that will be cherry picked into master)
/unhold

leogr
leogr previously approved these changes Oct 8, 2024
@poiana poiana added the lgtm label Oct 8, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 8, 2024

/hold
we want to merge #3372 too.

LucaGuerra and others added 3 commits October 8, 2024 12:07
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 8, 2024

/unhold

@poiana poiana merged commit 2804d60 into release/0.39.x Oct 8, 2024
32 checks passed
@poiana poiana deleted the sync/release_0391 branch October 8, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants