Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Deprecated loki documentation #996

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

afreyermuth98
Copy link
Contributor

@afreyermuth98 afreyermuth98 commented Sep 16, 2024

What type of PR is this?

Replaced the deprecated documentation about loki

Uncomment one (or more) /kind <> lines:

/kind documentation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area config

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: afreyermuth98 <anthofreyer@gmail.com>
@poiana
Copy link

poiana commented Sep 16, 2024

There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana
Copy link

poiana commented Sep 16, 2024

Welcome @afreyermuth98! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/S label Sep 16, 2024
@Issif Issif added this to the 2.30 milestone Sep 16, 2024
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. thank you

@poiana
Copy link

poiana commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreyermuth98, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Sep 16, 2024

LGTM label has been added.

Git tree hash: 97b8e324de55f36a2508a7813422ad24eb493d32

@poiana poiana merged commit 2cec220 into falcosecurity:master Sep 16, 2024
5 checks passed
@afreyermuth98 afreyermuth98 deleted the docs/loki-endpoint branch September 16, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants