Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: images #60

Merged
merged 1 commit into from
Jul 27, 2023
Merged

new: images #60

merged 1 commit into from
Jul 27, 2023

Conversation

therealbobo
Copy link
Collaborator

@therealbobo therealbobo commented Jul 24, 2023

Introducing new images to test the libraries with. This includes all the necessary files (Dockerfiles and additional files) for image creation.

@FedeDP
Copy link
Collaborator

FedeDP commented Jul 24, 2023

Can you add a README under images/generated-images with some isntructions, and under images/static-images stating that these are the dockerfiles for the images used by the tool?
Thanks, and btw huge work!!

@FedeDP
Copy link
Collaborator

FedeDP commented Jul 26, 2023

/close

@poiana poiana closed this Jul 26, 2023
@poiana
Copy link

poiana commented Jul 26, 2023

@FedeDP: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP
Copy link
Collaborator

FedeDP commented Jul 26, 2023

/reopen

@poiana poiana reopened this Jul 26, 2023
@poiana
Copy link

poiana commented Jul 26, 2023

@FedeDP: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Copy link
Collaborator

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jul 27, 2023

LGTM label has been added.

Git tree hash: 286c433fa35fcfe79e9db275ff726e8dd6263247

@poiana poiana merged commit cec0131 into main Jul 27, 2023
1 check passed
@poiana poiana deleted the new/images branch July 27, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants