-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(cmake,driver): bumped libbpf to latest release (1.2.2). #1197
Conversation
Cleaned up some now useless lines in `modern_bpf/helpers/base/common.h`. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@@ -21,6 +21,8 @@ | |||
* to the others `PT_REGS_PARAM...` | |||
*/ | |||
|
|||
#ifndef PT_REGS_PARM6_CORE_SYSCALL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep them when building with system libbpf that is < 1.2.0 thus does not contain the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the case in some of our CI jobs.
/cc @Andreagit97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/milestone 0.12.0 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Cleaned up some now useless lines in
modern_bpf/helpers/base/common.h
to fix some build warnings when building with newer libbpf versions (see https://github.com/libbpf/libbpf/blob/master/src/bpf_tracing.h and the libbpf/libbpf@672401a commit)Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: