Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake,driver): bumped libbpf to latest release (1.2.2). #1197

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jul 13, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Cleaned up some now useless lines in modern_bpf/helpers/base/common.h to fix some build warnings when building with newer libbpf versions (see https://github.com/libbpf/libbpf/blob/master/src/bpf_tracing.h and the libbpf/libbpf@672401a commit)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(cmake): bumped libbpf to 1.2.2.

Cleaned up some now useless lines in `modern_bpf/helpers/base/common.h`.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@@ -21,6 +21,8 @@
* to the others `PT_REGS_PARAM...`
*/

#ifndef PT_REGS_PARM6_CORE_SYSCALL
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep them when building with system libbpf that is < 1.2.0 thus does not contain the change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the case in some of our CI jobs.

@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 13, 2023

/cc @Andreagit97

@poiana poiana requested a review from Andreagit97 July 13, 2023 11:01
Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 17, 2023

/milestone 0.12.0

@poiana poiana added this to the 0.12.0 milestone Jul 17, 2023
@poiana
Copy link
Contributor

poiana commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 02b8098 into master Jul 17, 2023
25 checks passed
@poiana poiana deleted the update/libbpf branch July 17, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants