-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix listen syscall backlog field size #1200
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oheifetz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please double check driver/SCHEMA_VERSION file. See versioning. |
@oheifetz thank you! Will help with the tests if needed. Also let us plan and coordinate this one with the loginuid fix PR as there will be a merge conflict depending on the order. Both of them will likely go into the release after 0.12.0 (due ~ July 21) aka they'll both have to wait 1-2 weeks. Also don't worry about the driver schema version, we will coordinate that as well. |
4c57a4f
to
be61939
Compare
@oheifetz could you use In addition, those are all the unit tests you can try locally, plus we have e2e tests, hope the READMEs give even more info and let us know if you have questions.
|
7a1378a
to
c4f08d5
Compare
c4f08d5
to
34e675f
Compare
re #1200 (comment) would you prefer checking on the failing tests first or would you prefer us directly helping? |
@incertum, thanks for sharing the local test list, I ran the driver_tests til now and got the impression that it suffices, now I am fixing the issues. Strange that there is no single commits that changed the SCHEMA and modified all files that I see failing. Regarding Are these runs equivalent? |
25b72e4
to
f8f4742
Compare
https://github.com/falcosecurity/libs/tree/master/test/libscap Apologies that's on us with having started migrating out test suites to libs/test ... We are working on updating developer docs everywhere, I'll keep this in mind when we get here. We bump the schema versions manually and there are other PRs that are already bumping them, let's see where we once we are ready to merge this one. |
/milestone driver-backlog |
Reported by: github issue falcosecurity#515 Signed-off-by: Ofer Heifetz <oheifetz@gmail.com>
f8f4742
to
9925b64
Compare
@oheifetz we did reach new consensus, see here #1192 (comment) and will not require a new event type in cases like here. Please accept our apologies for the unnecessary work we caused. Would you be willing to adjust these changes? If it's a consolation, I will also have to squash my changes in the loginuid PR ... |
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
1 similar comment
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reported by: github issue #515
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area API-version
/area driver-modern-bpf
/area libscap
/area libpman
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it: fix listen syscall backlog field size
Which issue(s) this PR fixes: issue 515 listen bullet
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: