-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix umount2 syscall flags type, add conversion helper function #1211
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oheifetz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please double check driver/SCHEMA_VERSION file. See versioning. |
@oheifetz just wanted to let you know, we are discussing in the other PR #1192 (comment) how to make the executive decision on when we absolutely need to bump the event given it's rather a long list of minor type miss casts. We will keep you updated, for now we are holding all these PRs until we have clarified the open questions. |
Hi @incertum,
If there are some additional builds I can run to confirm that it will not fail on CI it would be great |
hey @oheifetz yes if you want to reproduce the failure locally you have to put #ifdef MNT_FORCE
if (flags & MNT_FORCE)
res |= PPM_MNT_FORCE;
#endif
#ifdef MNT_DETACH
if (flags & MNT_DETACH)
res |= PPM_MNT_DETACH;
#endif
...
return res; The |
26481c7
to
3d9b845
Compare
/milestone driver-backlog |
- change the flags (param 1) from u32 to s32 - add a userspace to scap flag conversion helper routine Reported by: github issue falcosecurity#515 Signed-off-by: Ofer Heifetz <oheifetz@gmail.com>
Hi @incertum, |
@oheifetz probably not, I just pushed myself onto my branch. I have had such issues in the past and likely something in your settings changed or you need to setup a new ssh key or something. Please let us know if you keep having these issues after checking everything. |
47537db
to
a7e4fff
Compare
Reported by: github issue #515
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-bpf
/area driver-modern-bpf
/area libscap
/area libpman
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it: change the flags (param 1) from u32 to s32 and add a userspace to scap flag conversion helper routine
Which issue(s) this PR fixes: issue 515 umount2 bullet
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: