-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(userspace/libscap): properly apply driver_event_schema target properties #1215
Conversation
…perties. Signed-off-by: Federico Di Pierro <nierro92@gmail.com> Co-authored-by: Dima Kogan <dima@secretsauce.net>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 0.12.0 |
@@ -148,7 +148,7 @@ if(CMAKE_SYSTEM_NAME MATCHES "Linux") | |||
add_library(driver_event_schema | |||
../../driver/fillers_table.c) | |||
target_link_libraries(scap_event_schema driver_event_schema) | |||
set_scap_target_properties(scap_event_schema) | |||
set_scap_target_properties(driver_event_schema) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @gnosek
Ah so you found it too :D I'd rather kill it with fire: #1217 |
/hold |
/close in favor of #1217 |
/close |
@FedeDP: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1201
Special notes for your reviewer:
Does this PR introduce a user-facing change?: