-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(driver): support for init_module, finit_module syscalls #1242
feat(driver): support for init_module, finit_module syscalls #1242
Conversation
Please double check driver/API_VERSION file. See versioning. |
e3a3f18
to
fbd35a1
Compare
e2ed9cd
to
573995d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
Please double-check these tests in sinsp:
You will notice that they assert |
f8568da
to
6e847e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a last comment on flags and we have done :)
driver/modern_bpf/programs/tail_called/events/syscall_dispatched_events/finit_module.bpf.c
Outdated
Show resolved
Hide resolved
driver/modern_bpf/programs/tail_called/events/syscall_dispatched_events/finit_module.bpf.c
Outdated
Show resolved
Hide resolved
e6fcb08
to
508f605
Compare
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com> Co-Authored-By: Andrea Terzolo <andreaterzolo3@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com> Co-Authored-By: Andrea Terzolo <andreaterzolo3@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
508f605
to
9eea9b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 812b91bcdef34acd373e0220c101f27f968d812e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap
/area libpman
/area tests
Does this PR require a change in the driver versions?
/version driver-API-version-minor
What this PR does / why we need it:
This adds the support for init_module, finit_module syscalls.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: