-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix umount2 syscall flags type, add conversion helper function #1255
Conversation
Please double check driver/API_VERSION file. See versioning. /hold |
driver/modern_bpf/programs/tail_called/events/syscall_dispatched_events/umount2.bpf.c
Outdated
Show resolved
Hide resolved
without new events, the patch will become easier with just 3/4 files |
338ccd1
to
ac11cb5
Compare
334fd49
to
d71c567
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost done :)
driver/modern_bpf/programs/tail_called/events/syscall_dispatched_events/umount2.bpf.c
Outdated
Show resolved
Hide resolved
d71c567
to
db7ef95
Compare
- change the flags (param 1) from u32 to s32 - add a userspace to scap flag conversion helper routine Reported by: github issue falcosecurity#515 Signed-off-by: Ofer Heifetz <oheifetz@gmail.com>
db7ef95
to
87a8701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 255ba258e4e5398a23efe4a5e3a3180e03a9a54e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, incertum, oheifetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reported by: github issue #515
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area driver-bpf
/area driver-modern-bpf
/area libscap
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it: fix umount2 syscall flags type and add conversion helper function
Which issue(s) this PR fixes: github issue #515
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: