Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fcntl enter arguments to exit event #1304

Merged
merged 1 commit into from
Aug 25, 2023

Commits on Aug 22, 2023

  1. Add fcntl enter arguments to exit event

    For some filters on fcntl events, it's useful to have access to both
    the provided fd and cmd, which are parameters in the enter event, as
    well as the return value (e.g. the new fd, which is in the exit
    event).
    
    So add the enter event fields to the exit event. This matches the
    pattern we already use for lots of other events. Fcntl is a pretty old
    event, so we weren't following that pattern then.
    
    It's safe to add new fields to events to preserve backwards
    compatibility, but it's not safe to modify or reduce fields, so keep
    the parameters in the enter event.
    
    Also bump the schema minor version, as this adds fields to an existing
    event.
    
    Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
    mstemm committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    063db0a View commit details
    Browse the repository at this point in the history