Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(driver): unlinkat & linkat flags #1538

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

ecbadeaux
Copy link
Contributor

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area driver-bpf
/area driver-modern-bpf

Does this PR require a change in the driver versions?

I am not sure about this.

What this PR does / why we need it:

I am trying to address the issue where linkat and unlinkat is handling the flag params as an unsigned integer when it should be handling it as in int.

Which issue(s) this PR fixes:

part of #515
(partial fix other issues still remain in 515)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Everett Badeaux <everettc1810@gmail.com>
Copy link

github-actions bot commented Dec 4, 2023

Please double check driver/API_VERSION file. See versioning.

/hold

@incertum
Copy link
Contributor

incertum commented Dec 4, 2023

/hold

@ecbadeaux thanks! Let's defer this one after we have release 0.14.0 as I see some e2e test failures, we need to investigate more carefully.

@ecbadeaux
Copy link
Contributor Author

/hold

@ecbadeaux thanks! Let's defer this one after we have release 0.14.0 as I see some e2e test failures, we need to investigate more carefully.

@incertum can you rerun the pipeline and see if it maybe was a fluke? I know this has happened once before

@ecbadeaux
Copy link
Contributor Author

@incertum @FedeDP looks like this was indeed a fluke can I get an approval?

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/next-driver

/unhold

@poiana
Copy link
Contributor

poiana commented Dec 6, 2023

LGTM label has been added.

Git tree hash: 582aa07718322c4acd6823c4f3dd2d4f42b1485d

@poiana poiana added the approved label Dec 6, 2023
@ecbadeaux
Copy link
Contributor Author

@Andreagit97 Can you check this out?

@leogr
Copy link
Member

leogr commented Dec 11, 2023

/milestone next-driver

@poiana poiana added this to the next-driver milestone Dec 11, 2023
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, ecbadeaux, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8eb2fc2 into falcosecurity:master Dec 11, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants