Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(build): add individual cmake sanitizer options, enable in e2e #1721

Merged

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area CI

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

Does three things:

  • introduces cmake options USE_ASAN and USE_UBSAN
  • enables those in CI tests
  • also enables them in e2e

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@LucaGuerra
Copy link
Contributor Author

/milestone 0.15.0

@poiana poiana added this to the 0.15.0 milestone Mar 1, 2024
@poiana poiana added the size/M label Mar 1, 2024
@LucaGuerra LucaGuerra force-pushed the new/better-sanitizer-options-cmake branch 11 times, most recently from 5c1b39b to 5c324e4 Compare March 5, 2024 17:13
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra LucaGuerra force-pushed the new/better-sanitizer-options-cmake branch from 5c324e4 to 3897344 Compare March 5, 2024 19:33
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra LucaGuerra force-pushed the new/better-sanitizer-options-cmake branch from 3897344 to 8abe842 Compare March 6, 2024 08:53
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 6, 2024

LGTM label has been added.

Git tree hash: d586f96cbd48f13ae20e2d7ba0a9e5d518c589ad

@poiana
Copy link
Contributor

poiana commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9c538e0 into falcosecurity:master Mar 6, 2024
41 checks passed
@LucaGuerra LucaGuerra deleted the new/better-sanitizer-options-cmake branch March 11, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants