chore(test/libsinsp_e2e): use unique ptr e2e tests inspector #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
See actions/runner-images#9524 (comment) for the fix. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
|
/milestone 0.16.0 |
FedeDP
commented
Mar 18, 2024
| @@ -79,7 +79,6 @@ void event_capture::capture() | |||
| m_capture_started = true; | |||
| m_condition_started.notify_one(); | |||
| } | |||
| delete m_inspector; | |||
There was a problem hiding this comment.
No need to delete unique ptr anymore.
Also, sinsp dtor autoamtically calls stop capture and scap_close for us.
jasondellaluce
approved these changes
Mar 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 18, 2024
Closed
Merged
|
/milestone 0.15.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area tests
What this PR does / why we need it:
Also, this fixes recent CI issues; see actions/runner-images#9524 and actions/runner-images#9491.
Which issue(s) this PR fixes:
Fixes #1750
Special notes for your reviewer:
Does this PR introduce a user-facing change?: