Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github): enhance heuristics API_VERSION and SCHEMA_VERSION checks #1768

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

leogr
Copy link
Member

@leogr leogr commented Mar 27, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

The schema version patch number should be incremented when code changes don't break compatibility (e.g. bug fixes in filler code)

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Fillers were removed because they are usually related to the SCHEMA_VERSION.
`ppm_events_public.h` was added due to IOCTL codes.
Also, the addition of bpf maps usually affects the API.

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
Copy link
Member Author

leogr commented Mar 27, 2024

/close

closing and reopening to trigger the CI

@poiana poiana closed this Mar 27, 2024
@poiana
Copy link
Contributor

poiana commented Mar 27, 2024

@leogr: Closed this PR.

In response to this:

/close

closing and reopening to trigger the CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member Author

leogr commented Mar 27, 2024

/reopen

@poiana
Copy link
Contributor

poiana commented Mar 27, 2024

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana reopened this Mar 27, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Mar 27, 2024

/milestone 0.16.0

@poiana poiana added this to the 0.16.0 milestone Mar 27, 2024
@leogr leogr changed the title wip: chore(.github): enhance heuristics API_VERSION and SCHEMA_VERSION checks chore(.github): enhance heuristics API_VERSION and SCHEMA_VERSION checks Mar 27, 2024
@leogr
Copy link
Member Author

leogr commented Mar 27, 2024

/milestone 0.16.0

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 026ffe1 into master Mar 28, 2024
43 checks passed
@poiana poiana deleted the ci/api-and-schema-checks branch March 28, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants