From 1e7b4730775b81f15a2bdc5d8766a4d980d35898 Mon Sep 17 00:00:00 2001 From: Leonardo Grasso Date: Wed, 27 Mar 2024 10:35:27 +0100 Subject: [PATCH 1/2] chore(.github): add fillers in SCHEMA_VERSION checks The schema version patch number should be incremented when code changes don't break compatibility (e.g. bug fixes in filler code) Signed-off-by: Leonardo Grasso --- .github/workflows/driver-schema-version.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/driver-schema-version.yml b/.github/workflows/driver-schema-version.yml index b955efbea0..837064cb5c 100644 --- a/.github/workflows/driver-schema-version.yml +++ b/.github/workflows/driver-schema-version.yml @@ -6,6 +6,8 @@ name: Driver SCHEMA_VERSION checks on: pull_request_target: paths: + - 'driver/ppm_fillers.c' + - 'driver/bpf/fillers.h' - 'driver/event_table.c' - 'driver/ppm_events_public.h' - 'driver/event_stats.h' From da8e8cba444a077b37a35b34f7646a4474879143 Mon Sep 17 00:00:00 2001 From: Leonardo Grasso Date: Wed, 27 Mar 2024 10:53:49 +0100 Subject: [PATCH 2/2] chore(.github): new heuristics for API_VERSION checks Fillers were removed because they are usually related to the SCHEMA_VERSION. `ppm_events_public.h` was added due to IOCTL codes. Also, the addition of bpf maps usually affects the API. Signed-off-by: Leonardo Grasso --- .github/workflows/driver-api-version.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/driver-api-version.yml b/.github/workflows/driver-api-version.yml index 202b1b08a5..52d2019a20 100644 --- a/.github/workflows/driver-api-version.yml +++ b/.github/workflows/driver-api-version.yml @@ -6,8 +6,13 @@ name: Driver API_VERSION checks on: pull_request_target: paths: - - 'driver/ppm_fillers.c' - - 'driver/bpf/fillers.h' + - 'userspace/libscap/engine/bpf/**' + - 'userspace/libscap/engine/modern_bpf/**' + - 'userspace/libscap/engine/kmod/**' + - 'driver/ppm_events_public.h' + - 'driver/bpf/maps.h' + - 'driver/modern_bpf/maps/maps.h' + jobs: paths-filter: