Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip #1938

Closed
wants to merge 1 commit into from
Closed

wip #1938

wants to merge 1 commit into from

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 28, 2024

Just a PR to test and fix drivers CI.

@poiana
Copy link
Contributor

poiana commented Jun 28, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Perf diff from master - unit tests

     4.40%     +1.98%  [.] sinsp_thread_manager::find_thread
     3.44%     +1.41%  [.] sinsp_parser::process_event
     4.24%     -1.06%  [.] sinsp_evt::load_params
     1.81%     -0.90%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
    10.04%     +0.74%  [.] sinsp_parser::reset
     1.02%     -0.71%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_weak_release
     4.67%     -0.62%  [.] sinsp_evt::get_type
     1.61%     -0.62%  [.] sinsp_parser::event_cleanup
     1.51%     -0.62%  [.] libsinsp::sinsp_suppress::process_event
     0.95%     -0.47%  [.] sinsp_filter_check::parse_field_name

Perf diff from master - scap file

     3.50%     +5.27%  [.] sinsp_filter_check_event::extract_single
    20.92%     -4.44%  [.] sinsp_filter_check::extract_nocache
     6.89%     +3.47%  [.] sinsp_evt_formatter::tostring_withformat
    10.47%     -1.99%  [.] sinsp_filter_check::tostring
     6.69%     -1.86%  [.] sinsp_thread_manager::find_thread
     3.42%     +1.77%  [.] sinsp_evt::load_params
     3.37%     +1.74%  [.] 0x00000000000a6f90
     3.52%     +1.71%  [.] sinsp_filter_check::rawval_to_string
     3.50%     +1.64%  [.] formatted_dump
     3.16%     +1.60%  [.] libsinsp::runc::match_one_container_id

Heap diff from master - unit tests

total runtime: 0.01s.
calls to allocation functions: -1623 (-270500/s)
temporary memory allocations: -592 (-98666/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.01s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 2 (-333/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 28, 2024

I leave this open to further test the CI.

Copy link

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

@poiana
Copy link
Contributor

poiana commented Jun 28, 2024

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

Perf diff from master - unit tests

     7.25%     +1.49%  [.] sinsp::next
     5.42%     -1.31%  [.] sinsp_evt::get_type
     0.60%     +0.93%  [.] scap_event_encode_params_v
     0.63%     +0.81%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
    10.87%     -0.79%  [.] sinsp_parser::reset
     1.37%     -0.74%  [.] sinsp_evt::get_ts
     5.05%     +0.65%  [.] next
     0.49%     +0.62%  [.] sinsp_filter_check::parse_field_name
     3.04%     +0.57%  [.] sinsp_thread_manager::get_thread_ref
     1.11%     -0.50%  [.] 0x00000000000e7390

Perf diff from master - scap file

     8.79%     +6.63%  [.] sinsp_filter_check::tostring
    20.14%     -6.39%  [.] sinsp_filter_check::extract_nocache
     8.79%     +2.59%  [.] sinsp_parser::reset
     5.39%     +2.34%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
    12.40%     +2.31%  [.] sinsp_evt_formatter::tostring_withformat
     6.32%     -1.87%  [.] sinsp_thread_manager::get_thread_ref
     5.75%     -1.52%  [.] sinsp_evt::get_thread_info
     4.25%     -0.63%  [.] sinsp_evt::get_type
     8.62%     +0.60%  [.] sinsp_filter_check::rawval_to_string
     2.52%     +0.46%  [.] libsinsp::container_engine::rkt::match

Heap diff from master - unit tests

total runtime: -0.15s.
calls to allocation functions: -327 (2137/s)
temporary memory allocations: -284 (1856/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: 0.06s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 6 (107/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 28, 2024

/close
Everything works fine!

@poiana poiana closed this Jun 28, 2024
@poiana
Copy link
Contributor

poiana commented Jun 28, 2024

@FedeDP: Closed this PR.

In response to this:

/close
Everything works fine!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants