feat(tests): new e2e tests [8/8] #1958

therealbobo · 2024-07-13T10:55:09Z

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This add new libsinsp e2e tests for the container runtimes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

github-actions · 2024-07-13T10:55:35Z

Please double check driver/API_VERSION file. See versioning.

/hold

github-actions · 2024-07-13T10:59:28Z

Perf diff from master - unit tests

     6.77%     -1.66%  [.] sinsp_evt::get_type
     4.60%     -0.85%  [.] gzfile_read
     0.83%     +0.63%  [.] sinsp_parser::event_cleanup
     0.44%     +0.62%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     1.72%     +0.59%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.45%     +0.58%  [.] scap_next
     6.94%     -0.58%  [.] sinsp::next
     4.71%     +0.51%  [.] next
     1.21%     -0.50%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     0.76%     +0.49%  [.] sinsp_filter_check::parse_field_name

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0175         -0.0175           153           151           153           151
BM_sinsp_split_median                                          -0.0197         -0.0197           153           150           153           150
BM_sinsp_split_stddev                                          +0.7413         +0.7424             2             3             2             3
BM_sinsp_split_cv                                              +0.7723         +0.7734             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0150         +0.0150            62            63            62            63
BM_sinsp_concatenate_paths_relative_path_median                +0.0083         +0.0083            61            62            61            62
BM_sinsp_concatenate_paths_relative_path_stddev                +0.6110         +0.6107             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    +0.5872         +0.5868             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0550         -0.0550            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0504         -0.0504            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.7819         -0.7815             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.7692         -0.7688             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0139         -0.0139            64            63            64            63
BM_sinsp_concatenate_paths_absolute_path_median                -0.0147         -0.0147            64            63            64            63
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.4780         +0.4778             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.4988         +0.4987             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0061         +0.0061           392           395           392           395
BM_sinsp_split_container_image_median                          +0.0060         +0.0060           393           395           393           395
BM_sinsp_split_container_image_stddev                          -0.5883         -0.5874             3             1             3             1
BM_sinsp_split_container_image_cv                              -0.5908         -0.5899             0             0             0             0

github-actions · 2024-07-13T11:27:51Z

Perf diff from master - unit tests

     5.14%     -0.94%  [.] sinsp_thread_manager::find_thread
     0.72%     +0.86%  [.] 0x00000000000e8394
     4.27%     -0.84%  [.] sinsp_thread_manager::get_thread_ref
     3.04%     +0.59%  [.] gzfile_read
     2.78%     -0.59%  [.] scap_event_decode_params
     1.45%     -0.59%  [.] sinsp_parser::event_cleanup
     3.19%     -0.59%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     4.79%     +0.54%  [.] sinsp_evt::get_type
     5.26%     -0.52%  [.] next
     0.10%     +0.43%  [.] get_event_param_as<long>

Perf diff from master - scap file

    14.09%     -5.09%  [.] sinsp_filter_check_event::extract_single
    14.13%     -5.05%  [.] sinsp_parser::reset
     6.95%     +3.34%  [.] sinsp_evt_formatter::tostring_withformat
     6.98%     +3.01%  [.] gzfile_read
     9.14%     -2.44%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     7.06%     -1.34%  [.] next
     3.33%     +0.59%  [.] sinsp_filter_check::rawval_to_string
     3.49%     +0.51%  [.] sinsp_filter_check::extract
     3.55%     +0.48%  [.] sinsp_evt::get_thread_info
     3.55%     +0.48%  [.] sinsp_evt::get_param_as_str

Heap diff from master - unit tests

total runtime: 0.11s.
calls to allocation functions: -453 (-4233/s)
temporary memory allocations: -219 (-2046/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.00s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 8 (-4000/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

github-actions · 2024-07-13T13:16:02Z

Perf diff from master - unit tests

     5.23%     -0.79%  [.] next
     0.77%     +0.75%  [.] libsinsp::sinsp_suppress::process_event
    10.01%     -0.74%  [.] sinsp_parser::reset
     4.25%     -0.61%  [.] sinsp_thread_manager::get_thread_ref
     0.71%     +0.59%  [.] 0x00000000000e8394
     7.29%     -0.59%  [.] sinsp::next
     0.46%     +0.52%  [.] thread_group_info::get_first_thread
     0.76%     -0.52%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::find
     1.44%     -0.49%  [.] sinsp_parser::event_cleanup
     3.02%     +0.41%  [.] gzfile_read

Perf diff from master - scap file

    13.36%     -7.25%  [.] sinsp_filter_check::extract_nocache
     2.70%     +3.74%  [.] sinsp_filter_check_container::extract_single
     2.71%     +3.67%  [.] sinsp_evt::get_type
     6.95%     -3.10%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     5.16%     +2.09%  [.] sinsp_evt::load_params
     2.66%     +1.94%  [.] sinsp_filter_check::extract
     2.70%     +1.91%  [.] sinsp_evt::get_param_as_str
     5.41%     -1.81%  [.] main
     5.35%     -1.77%  [.] sinsp::next
     5.31%     -1.75%  [.] gzfile_read

Heap diff from master - unit tests

total runtime: -0.01s.
calls to allocation functions: -384 (25600/s)
temporary memory allocations: -277 (18466/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.00s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 3 (-1500/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

github-actions · 2024-07-13T21:20:35Z

Perf diff from master - unit tests

     4.33%     -1.36%  [.] sinsp_thread_manager::get_thread_ref
     2.81%     -0.79%  [.] scap_event_decode_params
     4.86%     -0.68%  [.] sinsp_evt::get_type
     0.87%     +0.62%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     0.79%     +0.54%  [.] libsinsp::sinsp_suppress::process_event
     0.73%     +0.54%  [.] 0x00000000000e8394
     5.21%     +0.49%  [.] sinsp_thread_manager::find_thread
     0.16%     +0.44%  [.] sinsp_fdtable::find
     4.86%     -0.44%  [.] sinsp_parser::process_event
     3.08%     +0.40%  [.] gzfile_read

Perf diff from master - scap file

    15.43%     -6.93%  [.] sinsp_filter_check::extract_nocache
    12.41%     -5.29%  [.] sinsp_parser::reset
     6.11%     +5.25%  [.] sinsp_evt_formatter::tostring_withformat
     2.67%     +4.15%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     3.13%     +4.08%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     8.03%     -2.73%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     3.12%     +2.19%  [.] sinsp_evt::get_thread_info
     6.13%     -1.84%  [.] gzfile_read
     6.18%     -1.62%  [.] sinsp::next
     3.07%     -0.57%  [.] sinsp_filter_check::extract

Heap diff from master - unit tests

total runtime: 0.08s.
calls to allocation functions: -250 (-3012/s)
temporary memory allocations: -118 (-1421/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: 0.00s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 7 (2333/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

github-actions · 2024-07-14T07:09:02Z

Perf diff from master - unit tests

     7.33%     -2.12%  [.] sinsp::next
     4.80%     -1.60%  [.] sinsp_parser::process_event
    10.07%     +1.57%  [.] sinsp_parser::reset
     1.45%     +0.95%  [.] sinsp_parser::event_cleanup
     2.78%     -0.72%  [.] scap_event_decode_params
     4.27%     -0.62%  [.] sinsp_thread_manager::get_thread_ref
     4.79%     +0.49%  [.] sinsp_evt::get_type
     0.78%     +0.47%  [.] libsinsp::sinsp_suppress::process_event
     0.36%     +0.43%  [.] sinsp_fdtable::find_ref
     0.76%     -0.42%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::find

Perf diff from master - scap file

     2.92%     +6.22%  [.] sinsp_filter_check::rawval_to_string
    12.37%     -6.00%  [.] sinsp_parser::reset
    12.34%     -5.98%  [.] sinsp_filter_check_event::extract_single
    15.38%     -3.64%  [.] sinsp_filter_check::extract_nocache
     6.09%     +3.00%  [.] sinsp_evt_formatter::tostring_withformat
     8.01%     -2.29%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     3.10%     +2.21%  [.] sinsp_filter_check::get_field_info
     6.16%     +1.72%  [.] sinsp::next
     6.23%     -1.05%  [.] main
     2.66%     +0.94%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>

Heap diff from master - unit tests

total runtime: -0.07s.
calls to allocation functions: -752 (10444/s)
temporary memory allocations: -384 (5333/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.00s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: -2 (1000/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

github-actions · 2024-07-14T07:44:34Z

Perf diff from master - unit tests

    10.07%     -1.12%  [.] sinsp_parser::reset
     5.26%     -0.84%  [.] next
     4.27%     -0.83%  [.] sinsp_thread_manager::get_thread_ref
     4.79%     +0.69%  [.] sinsp_evt::get_type
     2.77%     -0.66%  [.] scap_event_decode_params
     0.78%     +0.53%  [.] libsinsp::sinsp_suppress::process_event
     0.16%     +0.49%  [.] sinsp_fdtable::find
     1.29%     +0.39%  [.] sinsp::fetch_next_event
     0.57%     -0.34%  [.] sinsp_parser::parse_open_openat_creat_exit
     0.72%     +0.32%  [.] 0x00000000000e8394

Perf diff from master - scap file

    11.37%     -5.53%  [.] sinsp_parser::reset
    11.34%     -5.51%  [.] sinsp_filter_check_event::extract_single
    14.13%     -3.82%  [.] sinsp_filter_check::extract_nocache
     2.44%     +3.57%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     5.60%     +3.55%  [.] sinsp_evt_formatter::tostring_withformat
     5.68%     +3.33%  [.] next
     5.61%     -1.87%  [.] gzfile_read
     5.66%     -1.86%  [.] sinsp::next
     2.68%     +1.78%  [.] sinsp_filter_check::rawval_to_string
     5.46%     -1.73%  [.] sinsp_evt::load_params

Heap diff from master - unit tests

total runtime: 0.06s.
calls to allocation functions: -525 (-8467/s)
temporary memory allocations: -303 (-4887/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.01s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 5 (-416/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

github-actions · 2024-07-14T08:14:20Z

Perf diff from master - unit tests

     4.80%     -1.65%  [.] sinsp_parser::process_event
     7.33%     -1.36%  [.] sinsp::next
     3.19%     -1.01%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     4.27%     -0.99%  [.] sinsp_thread_manager::get_thread_ref
     0.78%     +0.86%  [.] libsinsp::sinsp_suppress::process_event
     0.72%     +0.65%  [.] 0x00000000000e8394
     2.78%     -0.62%  [.] scap_event_decode_params
     5.14%     +0.56%  [.] sinsp_thread_manager::find_thread
     0.66%     +0.54%  [.] sinsp_threadinfo::~sinsp_threadinfo
     0.16%     +0.54%  [.] sinsp_fdtable::find

Perf diff from master - scap file

     6.73%    +19.64%  [.] sinsp_evt_formatter::tostring_withformat
    16.99%     -4.20%  [.] sinsp_filter_check::extract_nocache
    13.67%     -4.00%  [.] sinsp_parser::reset
     3.38%     +3.15%  [.] sinsp_filter_check::extract
    13.63%     -2.33%  [.] sinsp_filter_check_event::extract_single
     6.83%     -2.06%  [.] next
     6.88%     -2.02%  [.] main
     6.57%     -1.86%  [.] sinsp_evt::load_params
     3.23%     +1.72%  [.] sinsp_filter_check::rawval_to_string
     2.92%     +1.54%  [.] libsinsp::runc::match_container_id

Heap diff from master - unit tests

total runtime: 0.10s.
calls to allocation functions: -365 (-3613/s)
temporary memory allocations: -190 (-1881/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.005000s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 0 (0/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

github-actions · 2024-07-14T09:11:02Z

Perf diff from master - unit tests

     4.81%     +1.04%  [.] sinsp_evt::get_type
     2.78%     -0.79%  [.] scap_event_decode_params
     0.78%     +0.76%  [.] libsinsp::sinsp_suppress::process_event
     4.81%     -0.74%  [.] sinsp_parser::process_event
     7.35%     -0.72%  [.] sinsp::next
     4.28%     -0.72%  [.] sinsp_thread_manager::get_thread_ref
     0.57%     -0.43%  [.] copy_and_sanitize_path
     1.30%     +0.40%  [.] sinsp::fetch_next_event
     0.67%     +0.39%  [.] sinsp_threadinfo::~sinsp_threadinfo
     5.16%     +0.38%  [.] sinsp_thread_manager::find_thread

Perf diff from master - scap file

    12.00%     -5.43%  [.] sinsp_filter_check_event::extract_single
     5.94%     +3.62%  [.] gzfile_read
     3.02%     +3.61%  [.] sinsp_filter_check::get_field_info
    12.03%     -3.09%  [.] sinsp_parser::reset
     3.03%     +2.91%  [.] sinsp_evt::get_type
     2.84%     +2.00%  [.] sinsp_filter_check::rawval_to_string
     3.00%     +1.89%  [.] rawstring_check::extract_single
     6.05%     -1.83%  [.] main
     5.78%     -1.64%  [.] sinsp_evt::load_params
    14.96%     -1.60%  [.] sinsp_filter_check::extract_nocache

Heap diff from master - unit tests

total runtime: 0.04s.
calls to allocation functions: -536 (-11911/s)
temporary memory allocations: -327 (-7266/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.01s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 1 (-100/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

github-actions · 2024-07-14T09:40:48Z

Perf diff from master - unit tests

     5.19%     +0.99%  [.] sinsp_thread_manager::find_thread
     4.31%     -0.89%  [.] sinsp_thread_manager::get_thread_ref
    10.16%     +0.74%  [.] sinsp_parser::reset
     4.84%     -0.65%  [.] sinsp_parser::process_event
     3.22%     -0.58%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     0.16%     +0.49%  [.] sinsp_fdtable::find
     0.05%     +0.46%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_emplace<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >
     0.72%     +0.44%  [.] 0x00000000000e8394
     0.78%     +0.36%  [.] libsinsp::sinsp_suppress::process_event
     1.70%     -0.35%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>

Perf diff from master - scap file

     5.73%     +7.17%  [.] sinsp_evt_formatter::tostring_withformat
    11.65%     -5.53%  [.] sinsp_parser::reset
    11.62%     -3.80%  [.] sinsp_filter_check_event::extract_single
    14.48%     -3.76%  [.] sinsp_filter_check::extract_nocache
     2.49%     +3.71%  [.] libsinsp::runc::match_container_id
     5.86%     -1.95%  [.] main
     5.75%     -1.81%  [.] gzfile_read
     5.80%     +1.56%  [.] sinsp::next
     7.54%     -1.37%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     2.85%     -0.21%  [.] sinsp_split

Heap diff from master - unit tests

total runtime: 0.05s.
calls to allocation functions: -1236 (-23320/s)
temporary memory allocations: -567 (-10698/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.01s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 1 (-142/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

FedeDP · 2024-08-27T11:52:14Z

Given that #1650 is being tracked for 0.19, let's move this too:
/milestone 0.19.0

codecov · 2024-10-07T10:16:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (2b1e402) to head (2e7924e).
Report is 7 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1958   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         253      253           
  Lines       31914    31914           
  Branches     5642     5638    -4     
=======================================
+ Hits        23519    23520    +1     
+ Misses       8395     8376   -19     
- Partials        0       18   +18

Flag	Coverage Δ
libsinsp	`73.69% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>

test/libsinsp_e2e/container/container_cri.cpp

FedeDP · 2024-10-08T07:27:04Z

/milestone 0.19.0

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>

FedeDP

/approve

poiana · 2024-10-08T08:12:39Z

LGTM label has been added.

Git tree hash: 5c675b2b5a844aa32100d1ff6112a2e87939be80

poiana · 2024-10-08T08:12:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

FedeDP · 2024-10-08T10:53:22Z

/unhold

poiana added kind/feature New feature or request release-note-none do-not-merge/work-in-progress area/libscap-engine-bpf dco-signoff: yes labels Jul 13, 2024

poiana requested review from hbrueckner and incertum July 13, 2024 10:55

poiana added the size/XXL label Jul 13, 2024

poiana added the do-not-merge/hold label Jul 13, 2024

therealbobo force-pushed the fix-bpf-map-closing branch from 58b0732 to 29d6c69 Compare July 13, 2024 11:23

therealbobo force-pushed the fix-bpf-map-closing branch from bb260b3 to 4eb19c8 Compare July 14, 2024 07:04

therealbobo force-pushed the fix-bpf-map-closing branch from 4eb19c8 to de076fa Compare July 14, 2024 07:40

therealbobo force-pushed the fix-bpf-map-closing branch from de076fa to 17d6dbd Compare July 14, 2024 08:10

therealbobo force-pushed the fix-bpf-map-closing branch from 17d6dbd to 10a07e7 Compare July 14, 2024 09:06

therealbobo force-pushed the fix-bpf-map-closing branch from 10a07e7 to 8565fb0 Compare July 14, 2024 09:36

Andreagit97 added this to the TBD milestone Aug 27, 2024

therealbobo force-pushed the fix-bpf-map-closing branch from 8565fb0 to abe2b5a Compare October 7, 2024 10:05

therealbobo force-pushed the fix-bpf-map-closing branch from abe2b5a to 562de0e Compare October 7, 2024 11:21

therealbobo force-pushed the fix-bpf-map-closing branch from 4d20450 to aa91d5f Compare October 7, 2024 15:32

therealbobo and others added 2 commits October 7, 2024 15:34

new(test/libsinsp_e2e): add container cri tests

43aaeb4

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>

fix(libsinsp_e2e): remove user and group after test

a3a6e55

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>

therealbobo force-pushed the fix-bpf-map-closing branch from aa91d5f to 839a6b7 Compare October 7, 2024 15:34

therealbobo added 2 commits October 7, 2024 16:01

chore(libsinsp_e2e): drop python2

c8b0714

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>

chore: code formatting

a4b71e8

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>

therealbobo force-pushed the fix-bpf-map-closing branch from 839a6b7 to a4b71e8 Compare October 7, 2024 16:01

therealbobo marked this pull request as ready for review October 7, 2024 16:30

poiana removed the do-not-merge/work-in-progress label Oct 7, 2024

poiana requested a review from gnosek October 7, 2024 16:30

therealbobo changed the title ~~feat(tests): new e2e tests [8/N]~~ feat(tests): new e2e tests [8/8] Oct 7, 2024

therealbobo requested a review from FedeDP October 7, 2024 16:30

FedeDP reviewed Oct 8, 2024

View reviewed changes

test/libsinsp_e2e/container/container_cri.cpp Show resolved Hide resolved

poiana modified the milestones: TBD, 0.19.0 Oct 8, 2024

therealbobo added 2 commits October 8, 2024 07:32

fix(libsinsp_e2e): restore docker socket path after test

5452cd7

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>

fix(libsinsp_e2e): filter using tid

2e7924e

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>

FedeDP approved these changes Oct 8, 2024

View reviewed changes

poiana assigned FedeDP Oct 8, 2024

poiana added the lgtm label Oct 8, 2024

poiana added the approved label Oct 8, 2024

leogr approved these changes Oct 8, 2024

View reviewed changes

poiana assigned leogr Oct 8, 2024

poiana removed the do-not-merge/hold label Oct 8, 2024

poiana merged commit 3712714 into falcosecurity:master Oct 8, 2024
49 checks passed

therealbobo mentioned this pull request Oct 17, 2024

[TRACKING] End-to-End Test Contribution Proposal #1650

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tests): new e2e tests [8/8] #1958

feat(tests): new e2e tests [8/8] #1958

therealbobo commented Jul 13, 2024

github-actions bot commented Jul 13, 2024

github-actions bot commented Jul 13, 2024 •

edited

Loading

github-actions bot commented Jul 13, 2024

github-actions bot commented Jul 13, 2024

github-actions bot commented Jul 13, 2024

github-actions bot commented Jul 14, 2024

github-actions bot commented Jul 14, 2024

github-actions bot commented Jul 14, 2024

github-actions bot commented Jul 14, 2024

github-actions bot commented Jul 14, 2024

FedeDP commented Aug 27, 2024

codecov bot commented Oct 7, 2024 •

edited

Loading

FedeDP commented Oct 8, 2024

FedeDP left a comment

poiana commented Oct 8, 2024

poiana commented Oct 8, 2024

FedeDP commented Oct 8, 2024

feat(tests): new e2e tests [8/8] #1958

feat(tests): new e2e tests [8/8] #1958

Conversation

therealbobo commented Jul 13, 2024

github-actions bot commented Jul 13, 2024

github-actions bot commented Jul 13, 2024 • edited Loading

Perf diff from master - unit tests

Heap diff from master - unit tests

Heap diff from master - scap file

Benchmarks diff from master

github-actions bot commented Jul 13, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

github-actions bot commented Jul 13, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

github-actions bot commented Jul 13, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

github-actions bot commented Jul 14, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

github-actions bot commented Jul 14, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

github-actions bot commented Jul 14, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

github-actions bot commented Jul 14, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

github-actions bot commented Jul 14, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

FedeDP commented Aug 27, 2024

codecov bot commented Oct 7, 2024 • edited Loading

Codecov Report

FedeDP commented Oct 8, 2024

FedeDP left a comment

Choose a reason for hiding this comment

poiana commented Oct 8, 2024

poiana commented Oct 8, 2024

FedeDP commented Oct 8, 2024

github-actions bot commented Jul 13, 2024 •

edited

Loading

codecov bot commented Oct 7, 2024 •

edited

Loading