Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(ci): pin deps to hashes #1967

Merged

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area CI

Does this PR require a change in the driver versions?

As per title. According to supply chain security standards we currently employ.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
Copy link

Perf diff from master - unit tests

     6.38%     +2.87%  [.] sinsp::next
     3.94%     -0.83%  [.] gzfile_read
     4.69%     -0.82%  [.] sinsp_evt::load_params
     2.82%     -0.81%  [.] sinsp_thread_manager::get_thread_ref
     1.51%     -0.81%  [.] scap_next
     4.52%     -0.80%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     9.97%     +0.77%  [.] sinsp_parser::reset
     3.94%     +0.73%  [.] sinsp_evt::get_type
     1.79%     -0.59%  [.] libsinsp::sinsp_suppress::process_event
     0.27%     +0.45%  [.] libsinsp::runc::match_container_id

Perf diff from master - scap file

    14.07%     -7.05%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     3.57%     +5.40%  [.] sinsp_filter_check::tostring
     7.02%     +5.09%  [.] sinsp_filter_check::extract_nocache
    10.49%     -4.87%  [.] next
    10.02%     -4.73%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     7.13%     -2.64%  [.] sinsp_evt_formatter::tostring_withformat
     3.49%     +1.58%  [.] sinsp_evt::get_param_as_str
     3.57%     +1.55%  [.] sinsp_filter_check::get_field_info
     5.41%     -1.53%  [.] sinsp_threadinfo::~sinsp_threadinfo
     3.56%     +1.43%  [.] sinsp_evt::get_type

Heap diff from master - unit tests

total runtime: -0.04s.
calls to allocation functions: -799 (22194/s)
temporary memory allocations: -206 (5722/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.01s.
calls to allocation functions: -1 (200/s)
temporary memory allocations: -2 (400/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 19, 2024

LGTM label has been added.

Git tree hash: 5f9c9c601c5af3f7da80ca941c52b4736911c255

@Andreagit97 Andreagit97 added this to the 0.18.0 milestone Jul 19, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 7bfbf69 into falcosecurity:master Jul 19, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants