Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: fix(cmake/modules): propagate cmake toolchain file to deps #1978

Conversation

therealbobo
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This properly propagates the cmake toolchain to the project dependencies.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: therealbobo
Once this PR has been reviewed and has the lgtm label, please assign gnosek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Copy link

Perf diff from master - unit tests

     9.14%     +1.46%  [.] sinsp_parser::reset
     5.40%     -0.66%  [.] sinsp_evt::get_type
     0.23%     +0.63%  [.] copy_and_sanitize_path
     0.87%     +0.51%  [.] sinsp_threadinfo::~sinsp_threadinfo
     0.98%     -0.48%  [.] libsinsp::sinsp_suppress::process_event
     0.52%     -0.43%  [.] libsinsp::state::value_table_entry_adapter<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::dynamic_fields_t::dynamic_fields_t
     0.75%     +0.42%  [.] libsinsp::events::is_unknown_event
     1.54%     -0.38%  [.] 0x00000000000e83a0
     1.09%     -0.38%  [.] sinsp_evt::get_direction
     4.55%     -0.34%  [.] sinsp_evt::load_params

Perf diff from master - scap file

     2.97%     +4.60%  [.] sinsp_filter_check::tostring
     9.05%     -3.35%  [.] 0x00000000000a76b4
     3.16%     +2.20%  [.] sinsp_filter_check::get_field_info
     6.30%     -1.86%  [.] sinsp_threadinfo::~sinsp_threadinfo
     6.31%     -1.69%  [.] sinsp_filter_check::get_transformed_field_info
     9.47%     -1.45%  [.] sinsp_filter_check_thread::extract_single
    15.82%     -1.01%  [.] sinsp_evt_formatter::tostring_withformat
    12.53%     +0.86%  [.] sinsp_filter_check::extract_nocache
     6.32%     +0.45%  [.] sinsp_filter_check::rawval_to_string
     3.16%     +0.24%  [.] sinsp_filter_check::extract

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -30B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.98%. Comparing base (64fe187) to head (4e76e00).
Report is 145 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1978   +/-   ##
=======================================
  Coverage   50.98%   50.98%           
=======================================
  Files         310      310           
  Lines       39612    39612           
  Branches    17333    17324    -9     
=======================================
+ Hits        20197    20198    +1     
+ Misses      14340    14324   -16     
- Partials     5075     5090   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FedeDP FedeDP changed the title fix(cmake/modules): propagate cmake toolchain file to deps wip: fix(cmake/modules): propagate cmake toolchain file to deps Jul 31, 2024
@Andreagit97 Andreagit97 added this to the TBD milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants