Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bpf_engine): add some docs and rename some variables #1984

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind cleanup

/kind documentation

Any specific area of the project related to this PR?

/area libscap-engine-bpf

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

This PR adds some docs and renames some variables in the bpf engine

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Copy link

github-actions bot commented Aug 1, 2024

Please double check driver/API_VERSION file. See versioning.

/hold

Copy link

github-actions bot commented Aug 1, 2024

Perf diff from master - unit tests

     8.09%     -1.36%  [.] sinsp::next
     0.89%     +0.92%  [.] scap_event_encode_params_v
     0.72%     +0.83%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     9.16%     +0.77%  [.] sinsp_parser::reset
     4.68%     +0.71%  [.] next
     1.62%     +0.65%  [.] scap_event_decode_params
     1.02%     +0.63%  [.] sinsp_parser::event_cleanup
     4.31%     -0.56%  [.] sinsp_evt::load_params
     1.68%     +0.54%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.59%     +0.45%  [.] sinsp_evt::get_param

Perf diff from master - scap file

    14.88%     +6.13%  [.] sinsp_filter_check::extract_nocache
     9.53%     -3.63%  [.] sinsp_filter_check::rawval_to_string
    13.63%     -2.57%  [.] next
    13.96%     -2.29%  [.] sinsp_evt_formatter::tostring_withformat
     6.60%     -1.94%  [.] scap_event_decode_params
     6.24%     -1.76%  [.] sinsp_filter_check::get_transformed_field_info
     3.40%     +1.75%  [.] 0x00000000000a70e0
     6.27%     -1.75%  [.] sinsp_filter_check::tostring
     3.62%     -0.21%  [.] main
     6.13%     +0.20%  [.] sinsp_filter_check_event::extract_single

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 50.99%. Comparing base (3ce0a2d) to head (ab24259).
Report is 5 commits behind head on master.

Files Patch % Lines
userspace/libscap/engine/bpf/scap_bpf.h 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1984   +/-   ##
=======================================
  Coverage   50.98%   50.99%           
=======================================
  Files         310      310           
  Lines       39612    39609    -3     
  Branches    17793    17868   +75     
=======================================
  Hits        20197    20197           
- Misses      14350    14356    +6     
+ Partials     5065     5056    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Aug 1, 2024

LGTM label has been added.

Git tree hash: 7fb01af9eb0d34d072524f649092bd6df3dfab14

@poiana poiana merged commit 4a13e1b into falcosecurity:master Aug 6, 2024
44 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants