Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(libsinsp): update g_invalidchar for windows #1990

Merged
merged 1 commit into from
Aug 5, 2024
Merged

cleanup(libsinsp): update g_invalidchar for windows #1990

merged 1 commit into from
Aug 5, 2024

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area libsinsp

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

In some setups (Windows, for instance) the isprint() check might fail in debug mode for chars outside of that range.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

cleanup(libsinsp): do not crash on g_invalidchar in windows debug builds

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Perf diff from master - unit tests

     9.12%     +2.12%  [.] sinsp_parser::reset
     0.89%     +1.37%  [.] libsinsp::sinsp_suppress::process_event
     1.61%     +1.36%  [.] scap_event_decode_params
     8.05%     -1.32%  [.] sinsp::next
     3.27%     -1.32%  [.] sinsp_thread_manager::get_thread_ref
     1.43%     -1.11%  [.] scap_next
     1.19%     +0.80%  [.] sinsp::fetch_next_event
     4.29%     -0.75%  [.] sinsp_evt::load_params
     5.67%     +0.61%  [.] sinsp_evt::get_type
     4.65%     +0.60%  [.] next

Perf diff from master - scap file

     6.68%     +4.89%  [.] sinsp_filter_check_event::extract_single
     6.83%     +4.68%  [.] sinsp_filter_check::tostring
    10.39%     -3.40%  [.] sinsp_filter_check::rawval_to_string
    10.20%     -3.25%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     3.41%     +2.31%  [.] sinsp_thread_manager::get_thread_ref
     3.95%     +2.11%  [.] main
     3.41%     +1.96%  [.] sinsp_filter_check::extract
    15.22%     -1.68%  [.] sinsp_evt_formatter::tostring_withformat
     6.80%     -1.45%  [.] sinsp_filter_check::get_transformed_field_info
     3.42%     +1.33%  [.] sinsp_filter_check_thread::extract_single

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Perf diff from master - unit tests

     8.04%     -0.98%  [.] sinsp::next
     1.43%     -0.90%  [.] scap_next
     9.10%     +0.89%  [.] sinsp_parser::reset
     1.61%     +0.88%  [.] scap_event_decode_params
     0.60%     +0.69%  [.] sinsp_threadinfo::~sinsp_threadinfo
     5.30%     -0.62%  [.] sinsp_parser::process_event
     0.30%     +0.58%  [.] sinsp_split[abi:cxx11]
     2.56%     +0.46%  [.] sinsp_thread_manager::find_thread
     1.67%     +0.40%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.59%     +0.38%  [.] sinsp_evt::get_param

Perf diff from master - scap file

    11.64%     -6.10%  [.] next
    12.70%     +4.46%  [.] sinsp_filter_check::extract_nocache
     8.00%     -3.83%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     5.35%     +3.20%  [.] sinsp_filter_check::tostring
     2.66%     +2.98%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
    11.92%     -2.69%  [.] sinsp_evt_formatter::tostring_withformat
     7.01%     -2.38%  [.] sinsp_filter_check_container::extract_single
     2.65%     +1.64%  [.] gzfile_read
     2.68%     +1.59%  [.] sinsp_parser::process_event
     5.24%     +1.57%  [.] sinsp_filter_check_event::extract_single

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Perf diff from master - unit tests

     9.23%     +2.02%  [.] sinsp_parser::reset
     5.73%     -1.20%  [.] sinsp_evt::get_type
     1.63%     +1.16%  [.] scap_event_decode_params
     4.71%     +1.07%  [.] next
     4.10%     -0.86%  [.] gzfile_read
     1.45%     -0.79%  [.] scap_next
     5.37%     -0.71%  [.] sinsp_parser::process_event
     0.30%     +0.65%  [.] sinsp_split[abi:cxx11]
     1.70%     +0.58%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.72%     +0.57%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>

Perf diff from master - scap file

    14.44%     +5.16%  [.] sinsp_filter_check::extract_nocache
     3.03%     +4.61%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
    13.56%     -3.45%  [.] sinsp_evt_formatter::tostring_withformat
     9.09%     -3.07%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     8.98%     -3.02%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     5.95%     +2.95%  [.] sinsp_filter_check_event::extract_single
     3.05%     +2.73%  [.] sinsp_filter_check_thread::extract_single
     3.04%     +2.72%  [.] sinsp_thread_manager::get_thread_ref
     6.09%     -1.32%  [.] sinsp_filter_check::tostring
     9.26%     -0.92%  [.] sinsp_filter_check::rawval_to_string

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Perf diff from master - unit tests

     8.01%     -0.92%  [.] sinsp::next
     1.42%     -0.91%  [.] scap_next
     1.25%     +0.73%  [.] libsinsp::events::is_unknown_event
     1.18%     +0.73%  [.] sinsp::fetch_next_event
     4.63%     +0.53%  [.] next
     3.26%     -0.52%  [.] sinsp_thread_manager::get_thread_ref
     1.61%     +0.49%  [.] scap_event_decode_params
     0.30%     +0.48%  [.] sinsp_split[abi:cxx11]
     0.29%     +0.47%  [.] libsinsp::state::value_table_entry_adapter<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::dynamic_fields_t::dynamic_fields_t
     0.71%     +0.45%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>

Perf diff from master - scap file

    12.38%     -5.65%  [.] next
     2.47%     +3.97%  [.] sinsp_split[abi:cxx11]
     7.45%     -2.64%  [.] sinsp_filter_check_container::extract_single
     3.29%     +2.23%  [.] main
    12.68%     -1.54%  [.] sinsp_evt_formatter::tostring_withformat
     5.67%     -1.45%  [.] sinsp_filter_check::get_transformed_field_info
     8.66%     -1.18%  [.] sinsp_filter_check::rawval_to_string
     8.50%     -1.03%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     8.39%     +0.80%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     5.57%     +0.76%  [.] sinsp_filter_check_event::extract_single

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

@codecov Codecov
Copy link

codecov bot commented Aug 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.98%. Comparing base (2e87063) to head (a559a01).

Files Patch % Lines
userspace/libsinsp/utils.h 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #1990    +/-   ##
========================================
  Coverage   50.98%   50.98%            
========================================
  Files         310      310            
  Lines       39612    39613     +1     
  Branches    17455    17309   -146     
========================================
+ Hits        20197    20198     +1     
+ Misses      14338    14325    -13     
- Partials     5077     5090    +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucaGuerra
cleanup(libsinsp): update g_invalidchar for windows
a559a01 
Signed-off-by: Luca Guerra <luca@guerra.sh>
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Perf diff from master - unit tests

     1.68%     +0.79%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.39%     +0.79%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     8.05%     -0.78%  [.] sinsp::next
     1.61%     +0.65%  [.] scap_event_decode_params
     2.02%     -0.64%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     4.65%     +0.61%  [.] next
     4.05%     +0.61%  [.] gzfile_read
     5.31%     +0.52%  [.] sinsp_parser::process_event
     0.59%     +0.51%  [.] sinsp_evt::get_param
     1.07%     -0.42%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find

Perf diff from master - scap file

    11.52%     -6.19%  [.] next
     7.91%     -3.78%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
    12.57%     +3.15%  [.] sinsp_filter_check::extract_nocache
     2.71%     +3.00%  [.] sinsp_parser::reset
     2.65%     +2.98%  [.] sinsp_evt::get_param_as_str
     5.57%     -2.16%  [.] scap_event_decode_params
     2.64%     +1.55%  [.] sinsp_thread_manager::get_thread_ref
     2.63%     +1.39%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
    11.80%     -1.29%  [.] sinsp_evt_formatter::tostring_withformat
     3.06%     +1.13%  [.] main

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

@LucaGuerra
Copy link
Contributor Author

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Aug 5, 2024
Andreagit97
Andreagit97 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Aug 5, 2024
@poiana
Copy link
Contributor

poiana commented Aug 5, 2024

LGTM label has been added.

Git tree hash: 7c01178812d7e01d6212de59953630a633d03a12

jasondellaluce
jasondellaluce approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 85320ef into falcosecurity:master Aug 5, 2024
45 of 46 checks passed
@poiana
Copy link
Contributor

poiana commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,LucaGuerra,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@Molter73 Molter73 Awaiting requested review from Molter73

Assignees

@jasondellaluce jasondellaluce

@Andreagit97 Andreagit97

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup lgtm release-note size/XS
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@LucaGuerra @poiana @jasondellaluce @Andreagit97