Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(ci): update semgrep to 1.84.0 #1996

Merged

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area CI

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

As per title. It seems to be working fine now.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 7, 2024

LGTM label has been added.

Git tree hash: 28a5f90e52e2f2f2922bb86a5a2f2ade91ece107

Copy link

github-actions bot commented Aug 7, 2024

Perf diff from master - unit tests

    10.78%     +0.84%  [.] sinsp_parser::reset
     5.80%     -0.73%  [.] sinsp_evt::get_type
     5.27%     -0.55%  [.] sinsp_parser::process_event
     0.06%     +0.46%  [.] sinsp_plugin::sinsp_table_wrapper::write_entry_field
     0.22%     +0.41%  [.] sinsp_thread_manager::new_fdinfo
     0.72%     -0.41%  [.] libsinsp::runc::match_container_id
     7.92%     -0.37%  [.] sinsp::next
     0.99%     -0.36%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     0.22%     +0.36%  [.] libsinsp::state::value_table_entry_adapter<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::dynamic_fields_t::dynamic_fields_t
     1.15%     +0.36%  [.] sinsp::fetch_next_event

Perf diff from master - scap file

     2.95%     +4.99%  [.] sinsp_filter_check_thread::extract_single
     8.52%     +3.48%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     9.12%     -3.00%  [.] sinsp_filter_check::tostring
     8.85%     -2.91%  [.] sinsp_filter_check::rawval_to_string
     2.91%     +2.80%  [.] sinsp_filter_check::extract
    18.19%     -1.46%  [.] sinsp_filter_check::extract_nocache
     5.79%     +1.24%  [.] sinsp::next
     2.98%     +0.58%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     2.93%     +0.55%  [.] libsinsp::events::is_unknown_event
     2.97%     +0.53%  [.] libsinsp::sinsp_suppress::process_event

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.21%. Comparing base (ae812ee) to head (0025081).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1996      +/-   ##
==========================================
- Coverage   51.21%   51.21%   -0.01%     
==========================================
  Files         311      311              
  Lines       39671    39671              
  Branches    17929    17593     -336     
==========================================
- Hits        20317    20316       -1     
+ Misses      14262    14249      -13     
- Partials     5092     5106      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucaGuerra
Copy link
Contributor Author

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Aug 7, 2024
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, incertum, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,LucaGuerra,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 78d7312 into falcosecurity:master Aug 8, 2024
45 of 46 checks passed
@LucaGuerra LucaGuerra deleted the chore/update-semgrep-1.84.0 branch August 19, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants