fix(CI): restore e2e sinsp report uploading

[Andreagit97]

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

This PR restores the e2e sinsp report uploading by using the right path /tmp/report as suggested by @Molter73 in the below comments.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[github-actions]

Perf diff from master - unit tests

     2.05%     +0.88%  [.] sinsp_thread_manager::find_thread
     2.76%     +0.79%  [.] gzfile_read
     5.76%     -0.73%  [.] sinsp_evt::get_type
     1.20%     -0.59%  [.] sinsp_utils::find_longest_matching_evt_param
     1.54%     +0.49%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.00%     +0.45%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     0.61%     +0.44%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     1.07%     +0.42%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     0.72%     -0.41%  [.] copy_and_sanitize_path
     0.83%     -0.41%  [.] thread_group_info::get_first_thread

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.20%. Comparing base (434a230) to head (7c52afa).
Report is 7 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2024   +/-   ##
=======================================
  Coverage   74.20%   74.20%           
=======================================
  Files         253      253           
  Lines       30832    30832           
  Branches     5391     5406   +15     
=======================================
  Hits        22880    22880           
- Misses       7924     7940   +16     
+ Partials       28       12   -16     

Flag	Coverage Δ
libsinsp	74.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Andreagit97]

I'm trying to understand why the report is not uploaded when the e2e tests fail

I see this message here https://github.com/falcosecurity/libs/actions/runs/10576946353/job/29303855306#step:8:1

  with:
    name: bundled_deps_report
    path: /home/runner/work/libs/libs/build/report/
  
    if-no-files-found: warn
Warning: No files were found with the provided path: /home/runner/work/libs/libs/build/report/. No artifacts will be uploaded.

So it seems that for some reason the report is no longer generated under /home/runner/work/libs/libs/build/report/... any idea @Molter73 ?

[Andreagit97]

here i'm triggering a failure on purpose and I've added some ls just to check where this summary is stored in the container

[Molter73]

This one is on me, the report was being dump on /home/runner/work/libs/libs/build/report/ when the tests were run inside a container via a mount, but once it got changed to run locally on the VM it started dumping them to /tmp/report, we either need to change the script and cmake file to properly dump in /home/runner/work/libs/libs/build/report/ here and here or start uploading from /tmp/report here

[Andreagit97]

Thank you for the quick feedback! If it is ok for everyone I would just upload it to /tmp/report (so I would change here), it seems easier but let me know!

[Andreagit97]

I can confirm the fix is working! Now the report is uploaded again

[poiana]

LGTM label has been added.

Git tree hash: fab9360d92b8ff791882cec50413fb1fd0ffc1fa

[Molter73]

/lgtm

Sorry this has been broken for so long!

[FedeDP]

/approve

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, Molter73

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Andreagit97,FedeDP,Molter73]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment