-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CI): restore e2e sinsp report uploading #2024
Conversation
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2024 +/- ##
=======================================
Coverage 74.20% 74.20%
=======================================
Files 253 253
Lines 30832 30832
Branches 5391 5406 +15
=======================================
Hits 22880 22880
- Misses 7924 7940 +16
+ Partials 28 12 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
40abc91
to
7abce3f
Compare
I'm trying to understand why the report is not uploaded when the e2e tests fail I see this message here https://github.com/falcosecurity/libs/actions/runs/10576946353/job/29303855306#step:8:1
So it seems that for some reason the report is no longer generated under |
here i'm triggering a failure on purpose and I've added some |
This one is on me, the report was being dump on |
Thank you for the quick feedback! If it is ok for everyone I would just upload it to |
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
I can confirm the fix is working! Now the report is uploaded again |
LGTM label has been added. Git tree hash: fab9360d92b8ff791882cec50413fb1fd0ffc1fa
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sorry this has been broken for so long!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, Molter73 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area CI
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR restores the e2e sinsp report uploading by using the right path
/tmp/report
as suggested by @Molter73 in the below comments.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: