Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: reapply #1533 to check if perf framework does detect the slowdown #2029

Closed
wants to merge 2 commits into from

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Aug 28, 2024

As per title, just a test PR to check if the new perf framework is able to detect the slowdown that was caused by #1533

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana
Copy link
Contributor

poiana commented Aug 28, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana
Copy link
Contributor

poiana commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 28, 2024

/milestone TBD

(will close this asap!)

@poiana poiana added this to the TBD milestone Aug 28, 2024
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Copy link

Perf diff from master - unit tests

     7.24%     +1.32%  [.] sinsp::next
     6.54%     -1.24%  [.] next
     1.96%     -0.97%  [.] sinsp_evt::get_ts
     9.09%     +0.93%  [.] sinsp_parser::reset
     0.65%     +0.89%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     5.72%     -0.87%  [.] sinsp_evt::get_type
     3.06%     +0.75%  [.] gzfile_read
     2.51%     +0.69%  [.] sinsp_thread_manager::find_thread
     0.98%     -0.69%  [.] libsinsp::runc::match_container_id
     0.43%     +0.52%  [.] sinsp_parser::parse_open_openat_creat_exit

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 32B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0174         +0.0176           149           151           149           151
BM_sinsp_split_median                                          +0.0128         +0.0131           149           151           149           151
BM_sinsp_split_stddev                                          +2.8329         +2.8752             0             2             0             2
BM_sinsp_split_cv                                              +2.7672         +2.8080             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                 +20.7369        +20.7415            42           915            42           915
BM_sinsp_concatenate_paths_relative_path_median               +20.8403        +20.8455            42           913            42           913
BM_sinsp_concatenate_paths_relative_path_stddev                +6.8912         +6.9005             1             8             1             8
BM_sinsp_concatenate_paths_relative_path_cv                    -0.6370         -0.6366             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                    +30.9534        +30.9598            17           541            17           541
BM_sinsp_concatenate_paths_empty_path_median                  +31.0838        +31.0880            17           541            17           541
BM_sinsp_concatenate_paths_empty_path_stddev                  +14.9540        +14.9889             0             3             0             3
BM_sinsp_concatenate_paths_empty_path_cv                       -0.5007         -0.4997             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                 +13.9460        +13.9492            49           740            49           740
BM_sinsp_concatenate_paths_absolute_path_median               +13.9488        +13.9525            50           741            50           741
BM_sinsp_concatenate_paths_absolute_path_stddev               +11.3596        +11.3358             0             3             0             3
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.1731         -0.1748             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0027         -0.0025           354           354           354           353
BM_sinsp_split_container_image_median                          -0.0028         -0.0027           354           353           354           353
BM_sinsp_split_container_image_stddev                          -0.0254         -0.0225             2             2             2             2
BM_sinsp_split_container_image_cv                              -0.0228         -0.0201             0             0             0             0

@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 28, 2024

Caught!
/close

@poiana poiana closed this Aug 28, 2024
@poiana
Copy link
Contributor

poiana commented Aug 28, 2024

@FedeDP: Closed this PR.

In response to this:

Caught!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.15%. Comparing base (89edd36) to head (de8991d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2029      +/-   ##
==========================================
- Coverage   74.20%   74.15%   -0.05%     
==========================================
  Files         253      253              
  Lines       30832    30762      -70     
  Branches     5394     5399       +5     
==========================================
- Hits        22880    22813      -67     
- Misses       7934     7946      +12     
+ Partials       18        3      -15     
Flag Coverage Δ
libsinsp 74.15% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants