Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(semgrep): update semgrep docker image #2048

Merged

Conversation

francesco-furlan
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Semgrep has updated their official docker image to semgrep/semgrep

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Sep 9, 2024

Welcome @francesco-furlan! It looks like this is your first PR to falcosecurity/libs 🎉

@Andreagit97
Copy link
Member

Hi @francesco-furlan thank you for this! could you add the DCO to your commit as explained here https://github.com/falcosecurity/libs/blob/master/Contributing.md#add-dco-signed-off-to-your-commits- ?

Copy link

github-actions bot commented Sep 9, 2024

Perf diff from master - unit tests

Warning:
Processed 23526 events and lost 2 chunks!

Check IO/CPU overload!

     3.52%     +1.03%  [.] gzfile_read
     3.89%     -0.94%  [.] sinsp_thread_manager::get_thread_ref
     8.29%     -0.83%  [.] sinsp::next
    10.16%     -0.77%  [.] sinsp_parser::reset
     1.50%     -0.64%  [.] 0x00000000000e93c0

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0069         +0.0069           149           151           149           151
BM_sinsp_split_median                                          +0.0062         +0.0062           150           150           149           150
BM_sinsp_split_stddev                                          -0.4789         -0.4781             1             0             1             0
BM_sinsp_split_cv                                              -0.4825         -0.4817             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0347         -0.0347            47            46            47            46
BM_sinsp_concatenate_paths_relative_path_median                -0.0287         -0.0287            47            46            47            46
BM_sinsp_concatenate_paths_relative_path_stddev                -0.3328         -0.3328             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.3088         -0.3089             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0084         -0.0084            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.0023         -0.0024            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.3718         -0.3719             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.3664         -0.3666             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0249         -0.0249            51            50            51            50
BM_sinsp_concatenate_paths_absolute_path_median                -0.0227         -0.0227            51            50            51            50
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.6388         -0.6388             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.6296         -0.6296             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0036         +0.0036           352           353           352           353
BM_sinsp_split_container_image_median                          +0.0023         +0.0023           352           353           352           353
BM_sinsp_split_container_image_stddev                          +0.0683         +0.0692             2             2             2             2
BM_sinsp_split_container_image_cv                              +0.0644         +0.0653             0             0             0             0

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.10%. Comparing base (efa1df9) to head (56cd7fd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2048   +/-   ##
=======================================
  Coverage   74.10%   74.10%           
=======================================
  Files         254      254           
  Lines       31213    31213           
  Branches     5429     5422    -7     
=======================================
  Hits        23130    23130           
- Misses       8060     8073   +13     
+ Partials       23       10   -13     
Flag Coverage Δ
libsinsp 74.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Francesco Furlan <francesco.furlan@sysdig.com>
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 9, 2024

LGTM label has been added.

Git tree hash: 58b4b2e4d5c3f234fb69eca1278b5130bf895bc2

@poiana poiana added the approved label Sep 9, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, francesco-furlan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit dd16507 into falcosecurity:master Sep 9, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants