Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sinsp): plugin capture listen capability exception #2050

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

mrgian
Copy link
Contributor

@mrgian mrgian commented Sep 10, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(sinsp): plugin capture listen capability exception

@FedeDP
Copy link
Contributor

FedeDP commented Sep 10, 2024

/milestone 0.18.0

FedeDP
FedeDP previously approved these changes Sep 10, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 10, 2024

LGTM label has been added.

Git tree hash: 861c6c1c90e6e4e25ecaa42c9811c17872703f88

Copy link

github-actions bot commented Sep 10, 2024

Perf diff from master - unit tests

     6.14%     +2.39%  [.] sinsp::next
     1.62%     +0.86%  [.] scap_event_decode_params
     4.53%     -0.74%  [.] sinsp_evt::load_params
     1.95%     -0.71%  [.] libsinsp::sinsp_suppress::process_event
     0.84%     -0.63%  [.] thread_group_info::get_first_thread
    10.78%     -0.56%  [.] sinsp_parser::reset
     5.70%     -0.51%  [.] next
     4.75%     -0.50%  [.] sinsp_parser::process_event
     0.77%     -0.47%  [.] sinsp_fdtable::sinsp_fdtable
     5.75%     -0.46%  [.] sinsp_evt::get_type

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0111         +0.0111           146           148           146           148
BM_sinsp_split_median                                          +0.0091         +0.0091           147           148           147           148
BM_sinsp_split_stddev                                          -0.6501         -0.6500             2             1             2             1
BM_sinsp_split_cv                                              -0.6540         -0.6539             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0046         -0.0046            47            47            47            47
BM_sinsp_concatenate_paths_relative_path_median                +0.0001         +0.0002            47            47            47            47
BM_sinsp_concatenate_paths_relative_path_stddev                -0.7408         -0.7406             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.7396         -0.7394             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0071         -0.0070            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.0030         -0.0030            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.6657         -0.6655             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.6633         -0.6631             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0611         +0.0611            49            52            49            52
BM_sinsp_concatenate_paths_absolute_path_median                +0.0610         +0.0610            49            52            49            52
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.4648         -0.4647             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.4956         -0.4955             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0528         +0.0529           344           362           344           362
BM_sinsp_split_container_image_median                          +0.0525         +0.0526           344           362           344           362
BM_sinsp_split_container_image_stddev                          +1.8876         +1.8850             1             2             1             2
BM_sinsp_split_container_image_cv                              +1.7428         +1.7401             0             0             0             0

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.55%. Comparing base (215db2d) to head (e06d571).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
userspace/libsinsp/sinsp.cpp 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
- Coverage   73.57%   73.55%   -0.03%     
==========================================
  Files         253      253              
  Lines       31860    31863       +3     
  Branches     5640     5627      -13     
==========================================
- Hits        23442    23437       -5     
- Misses       8407     8413       +6     
- Partials       11       13       +2     
Flag Coverage Δ
libsinsp 73.55% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LucaGuerra
LucaGuerra previously approved these changes Sep 10, 2024
@Andreagit97
Copy link
Member

/hold

Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Sep 11, 2024
@poiana
Copy link
Contributor

poiana commented Sep 11, 2024

LGTM label has been added.

Git tree hash: 5d5cb6853a473bddf00e545c9c6c5076fbf1026c

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, mrgian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Sep 11, 2024

/unhold

@poiana poiana merged commit 0f75722 into falcosecurity:master Sep 11, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants