-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sinsp): rename thread_pool
to sinsp_thread_pool
to avoid symbol conflicts
#2065
chore(sinsp): rename thread_pool
to sinsp_thread_pool
to avoid symbol conflicts
#2065
Conversation
/milestone 0.18.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: f2ea11b3177b83b7e56ac59e9af6b5a21335005d
|
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2065 +/- ##
=======================================
Coverage 73.58% 73.58%
=======================================
Files 253 253
Lines 31867 31867
Branches 5656 5642 -14
=======================================
Hits 23449 23449
+ Misses 8418 8392 -26
- Partials 0 26 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d30b2bf
to
409167b
Compare
…mbol conflicts Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
409167b
to
894b33c
Compare
thread_pool
to sinsp_thread_pool
to avoid symbol conflicts
/milestone 0.19.0 Didn't notice this was a draft :) |
It wasn't :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 35580f0d4bfc1079c7153d0917ffb54d444b5253
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, mrgian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 0.18.0 |
What type of PR is this?
Any specific area of the project related to this PR?
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: