chore(sinsp): rename thread_pool to sinsp_thread_pool to avoid symbol conflicts

[mrgian]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[FedeDP]

/milestone 0.18.0

[FedeDP]

/approve

[poiana]

LGTM label has been added.

Git tree hash: f2ea11b3177b83b7e56ac59e9af6b5a21335005d

[github-actions]

Perf diff from master - unit tests

     5.07%     -1.30%  [.] sinsp_evt::load_params
     5.19%     +0.99%  [.] next
     3.72%     -0.82%  [.] sinsp_thread_manager::find_thread
     2.97%     +0.68%  [.] sinsp_thread_manager::get_thread_ref
     7.46%     -0.61%  [.] sinsp::next
     9.73%     -0.56%  [.] sinsp_parser::reset
     2.70%     -0.55%  [.] scap_event_decode_params
     0.64%     -0.40%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::find
     1.18%     -0.39%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     1.19%     -0.38%  [.] sinsp_evt::get_ts

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0301         +0.0301           147           151           147           151
BM_sinsp_split_median                                          +0.0309         +0.0309           147           151           147           151
BM_sinsp_split_stddev                                          -0.3234         -0.3240             1             1             1             1
BM_sinsp_split_cv                                              -0.3432         -0.3438             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0536         -0.0536            50            47            50            47
BM_sinsp_concatenate_paths_relative_path_median                -0.0575         -0.0576            50            47            50            47
BM_sinsp_concatenate_paths_relative_path_stddev                -0.7709         -0.7709             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.7579         -0.7579             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0047         -0.0047            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.0010         -0.0010            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.6376         -0.6375             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.6359         -0.6358             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0668         +0.0668            47            50            47            50
BM_sinsp_concatenate_paths_absolute_path_median                +0.0636         +0.0635            47            50            47            50
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3536         -0.3543             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.3941         -0.3947             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0141         +0.0141           352           357           352           357
BM_sinsp_split_container_image_median                          +0.0117         +0.0118           353           357           353           357
BM_sinsp_split_container_image_stddev                          +0.4153         +0.4149             2             3             2             3
BM_sinsp_split_container_image_cv                              +0.3956         +0.3952             0             0             0             0

[codecov]

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.58%. Comparing base (acc2d4e) to head (894b33c).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
userspace/libsinsp/plugin.cpp	0.00%	3 Missing ⚠️
userspace/libsinsp/sinsp.cpp	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2065   +/-   ##
=======================================
  Coverage   73.58%   73.58%           
=======================================
  Files         253      253           
  Lines       31867    31867           
  Branches     5656     5642   -14     
=======================================
  Hits        23449    23449           
+ Misses       8418     8392   -26     
- Partials        0       26   +26     

Flag	Coverage Δ
libsinsp	73.58% <16.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[FedeDP]

/milestone 0.19.0

Didn't notice this was a draft :)

[mrgian]

Didn't notice this was a draft :)

It wasn't :)
I took the opportunity to make another change in the same PR and I put it in draft just to let maintainers know to not to merge it yet (since it was already approved).
However, it is ready now!
@FedeDP This should be in milestone 0.18.0 IMO

[FedeDP]

/approve

[poiana]

LGTM label has been added.

Git tree hash: 35580f0d4bfc1079c7153d0917ffb54d444b5253

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, mrgian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[FedeDP]

/milestone 0.18.0
I agree!