fix(tests): flaky thread pool tests

[mrgian]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (6a0df22) to head (14d0135).
Report is 53 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2071   +/-   ##
=======================================
  Coverage   73.57%   73.57%           
=======================================
  Files         253      253           
  Lines       31875    31875           
  Branches     5648     5644    -4     
=======================================
  Hits        23452    23452           
+ Misses       8408     8399    -9     
- Partials       15       24    +9     

Flag	Coverage Δ
libsinsp	73.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Perf diff from master - unit tests

     6.97%     +1.89%  [.] sinsp::next
    10.26%     -1.24%  [.] sinsp_parser::reset
     4.56%     -1.01%  [.] sinsp_evt::load_params
     6.80%     -0.90%  [.] sinsp_evt::get_type
     1.72%     +0.86%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     4.73%     +0.85%  [.] next
     3.30%     -0.79%  [.] sinsp_thread_manager::find_thread
     2.34%     -0.76%  [.] sinsp::fetch_next_event
     0.50%     +0.74%  [.] scap_event_has_large_payload
     2.78%     +0.70%  [.] sinsp_thread_manager::get_thread_ref

Heap diff from master - unit tests

peak heap memory consumption: 82.48K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 3.65K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0078         +0.0078           153           154           153           154
BM_sinsp_split_median                                          +0.0114         +0.0114           153           155           153           155
BM_sinsp_split_stddev                                          -0.4008         -0.4005             2             1             2             1
BM_sinsp_split_cv                                              -0.4054         -0.4051             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0179         -0.0179            62            60            62            60
BM_sinsp_concatenate_paths_relative_path_median                -0.0142         -0.0142            61            60            61            60
BM_sinsp_concatenate_paths_relative_path_stddev                -0.7007         -0.7007             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.6952         -0.6953             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0113         -0.0112            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0145         -0.0145            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.5530         +0.5541             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.5707         +0.5718             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0166         -0.0165            64            63            64            63
BM_sinsp_concatenate_paths_absolute_path_median                -0.0159         -0.0159            64            63            64            63
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.0035         +0.0044             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.0204         +0.0213             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0086         +0.0086           392           396           392           396
BM_sinsp_split_container_image_median                          +0.0083         +0.0083           393           396           393           396
BM_sinsp_split_container_image_stddev                          -0.6410         -0.6405             3             1             3             1
BM_sinsp_split_container_image_cv                              -0.6441         -0.6436             0             0             0             0

[FedeDP]

/milestone TBD

[FedeDP]

/milestone 0.19.0

[FedeDP]

/approve

[poiana]

LGTM label has been added.

Git tree hash: 321aa486306f6228d392a1af7afc524b055104da

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, mrgian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment