chore(ci): show diff on failed format

[Molter73]

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

The provided patch is great to fix large formatting errors, however, it would be nice for CI to also show the diff for smaller changes that could be directly typed without having to download the patch.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.58%. Comparing base (aeb8793) to head (688bc89).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2090      +/-   ##
==========================================
- Coverage   73.58%   73.58%   -0.01%     
==========================================
  Files         253      253              
  Lines       31869    31869              
  Branches     5649     5626      -23     
==========================================
- Hits        23452    23451       -1     
+ Misses       8416     8389      -27     
- Partials        1       29      +28     

Flag	Coverage Δ
libsinsp	73.58% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Perf diff from master - unit tests

     9.12%     +2.24%  [.] sinsp_parser::reset
     8.90%     -1.84%  [.] sinsp::next
     1.18%     +0.92%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     4.17%     +0.80%  [.] sinsp_evt::load_params
     1.26%     -0.52%  [.] sinsp_evt::get_direction
     0.55%     +0.48%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::find
     5.47%     -0.39%  [.] sinsp_evt::get_type
     0.44%     -0.35%  [.] sinsp_threadinfo::get_fd
     0.10%     +0.35%  [.] libsinsp::state::value_table_entry_adapter<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::dynamic_fields_t::dynamic_fields_t
     0.38%     +0.35%  [.] sinsp_parser::parse_rw_exit

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0651         +0.0651           147           157           147           157
BM_sinsp_split_median                                          +0.0676         +0.0676           147           157           147           157
BM_sinsp_split_stddev                                          +2.5043         +2.5047             0             2             0             2
BM_sinsp_split_cv                                              +2.2901         +2.2905             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0904         +0.0904            57            62            57            62
BM_sinsp_concatenate_paths_relative_path_median                +0.0910         +0.0910            57            62            57            62
BM_sinsp_concatenate_paths_relative_path_stddev                +0.2025         +0.2035             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.1028         +0.1037             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0082         +0.0082            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0142         +0.0142            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.6855         -0.6853             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.6880         -0.6879             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1314         +0.1314            57            64            57            64
BM_sinsp_concatenate_paths_absolute_path_median                +0.1281         +0.1281            56            64            56            64
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.6578         +0.6578             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.4652         +0.4652             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0149         -0.0149           402           396           402           396
BM_sinsp_split_container_image_median                          -0.0178         -0.0178           403           396           403           396
BM_sinsp_split_container_image_stddev                          -0.2509         -0.2507             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.2396         -0.2394             0             0             0             0

[FedeDP]

/approve

Agree with the proposed change!

[poiana]

LGTM label has been added.

Git tree hash: 94e58532945cf01a25cf54eab8b78d9d9bbfb874

[FedeDP]

/milestone 0.19.0

[Andreagit97]

/approve

thank you

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, Molter73

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Andreagit97,FedeDP,Molter73]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment