-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(libsinsp): print LIST() in markdown format for list fields #2091
new(libsinsp): print LIST() in markdown format for list fields #2091
Conversation
Signed-off-by: Luca Guerra <luca@guerra.sh>
adaabe2
to
c6e512f
Compare
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2091 +/- ##
==========================================
- Coverage 73.58% 73.57% -0.02%
==========================================
Files 253 253
Lines 31869 31875 +6
Branches 5649 5663 +14
==========================================
- Hits 23452 23451 -1
- Misses 8416 8424 +8
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM label has been added. Git tree hash: ae9a0ae521903815de43be20cd35e7b3c207d285
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 0.19.0 |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
Currently the documentation website lists field arguments as if they were regular. If they are lists of charbufs for example we would like to print
LIST(CHARBUF)
instead ofCHARBUF
. This PR does exactly that.Which issue(s) this PR fixes:
Fixes #2092
Special notes for your reviewer:
Does this PR introduce a user-facing change?: