Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix kernel testing action by using proper tag name. #2108

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Oct 10, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Second time it happens :/ bug added in #2096

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 10, 2024

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Oct 10, 2024
@poiana poiana added the size/XS label Oct 10, 2024
Copy link

Perf diff from master - unit tests

    11.10%     -2.77%  [.] sinsp_parser::reset
     4.24%     +1.32%  [.] next
     0.63%     +1.07%  [.] sinsp_filter_check::parse_field_name
     6.18%     +1.03%  [.] sinsp::next
     1.08%     +0.73%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     3.92%     +0.52%  [.] sinsp_evt::load_params
     1.43%     -0.48%  [.] libsinsp::events::is_unknown_event
     1.31%     -0.47%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     0.83%     -0.46%  [.] std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, true> > >::_M_deallocate_nodes
     0.40%     +0.45%  [.] scap_event_has_large_payload

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0248         -0.0248           153           149           153           149
BM_sinsp_split_median                                          -0.0262         -0.0262           153           149           153           149
BM_sinsp_split_stddev                                          +0.1027         +0.1017             1             2             1             2
BM_sinsp_split_cv                                              +0.1307         +0.1297             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0858         -0.0858            63            58            63            58
BM_sinsp_concatenate_paths_relative_path_median                -0.0809         -0.0809            63            58            63            58
BM_sinsp_concatenate_paths_relative_path_stddev                +1.2575         +1.2563             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +1.4694         +1.4680             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0154         -0.0154            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0146         -0.0146            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.0089         -0.0069             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.0066         +0.0087             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0729         -0.0729            61            57            61            57
BM_sinsp_concatenate_paths_absolute_path_median                -0.0627         -0.0627            61            57            61            57
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.7353         -0.7353             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.7145         -0.7144             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0030         +0.0030           396           397           396           397
BM_sinsp_split_container_image_median                          +0.0018         +0.0018           396           397           396           397
BM_sinsp_split_container_image_stddev                          -0.2980         -0.2975             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.3001         -0.2996             0             0             0             0

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (06ab7c4) to head (d96c7f4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2108      +/-   ##
==========================================
- Coverage   73.69%   73.69%   -0.01%     
==========================================
  Files         253      253              
  Lines       31914    31914              
  Branches     5610     5626      +16     
==========================================
- Hits        23520    23519       -1     
- Misses       8364     8381      +17     
+ Partials       30       14      -16     
Flag Coverage Δ
libsinsp 73.69% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 6d2bec3 into master Oct 10, 2024
49 checks passed
@poiana poiana deleted the fix/kernel-testing-action branch October 10, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants