Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use local zig folder instead of /usr/local. #2129

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Oct 22, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 22, 2024

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Oct 22, 2024
@poiana poiana added the size/S label Oct 22, 2024
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (6322a02) to head (199d685).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2129   +/-   ##
=======================================
  Coverage   74.46%   74.46%           
=======================================
  Files         254      254           
  Lines       33333    33333           
  Branches     5707     5702    -5     
=======================================
  Hits        24821    24821           
- Misses       8481     8482    +1     
+ Partials       31       30    -1     
Flag Coverage Δ
libsinsp 74.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…-kernel workflow.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Copy link

Perf diff from master - unit tests

     9.28%     +1.08%  [.] sinsp_parser::reset
     5.44%     -1.06%  [.] next
     0.73%     +0.75%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     3.12%     -0.74%  [.] sinsp_thread_manager::find_thread
     5.28%     -0.62%  [.] sinsp_evt::get_type
     2.34%     -0.56%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     1.05%     +0.46%  [.] sinsp_parser::parse_context_switch
     1.06%     -0.44%  [.] sinsp_parser::event_cleanup
     0.16%     +0.39%  [.] get_event_param_as<long>
     0.68%     -0.39%  [.] sinsp_container_info::sinsp_container_info

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0009         +0.0008           149           149           149           149
BM_sinsp_split_median                                          -0.0011         -0.0011           149           149           149           149
BM_sinsp_split_stddev                                          -0.7195         -0.7193             2             0             2             0
BM_sinsp_split_cv                                              -0.7198         -0.7196             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0371         -0.0371            58            56            58            56
BM_sinsp_concatenate_paths_relative_path_median                -0.0310         -0.0310            57            56            57            56
BM_sinsp_concatenate_paths_relative_path_stddev                -0.7802         -0.7802             2             0             2             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.7717         -0.7717             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0194         +0.0193            23            24            23            24
BM_sinsp_concatenate_paths_empty_path_median                   +0.0203         +0.0203            23            24            23            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.5997         -0.6009             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.6073         -0.6085             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0618         -0.0618            59            55            59            55
BM_sinsp_concatenate_paths_absolute_path_median                -0.0780         -0.0781            60            55            60            55
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.6772         -0.6772             3             1             3             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.6560         -0.6560             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0324         +0.0324           389           402           389           402
BM_sinsp_split_container_image_median                          +0.0322         +0.0322           389           402           389           402
BM_sinsp_split_container_image_stddev                          -0.5219         -0.5217             4             2             4             2
BM_sinsp_split_container_image_cv                              -0.5369         -0.5367             0             0             0             0

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b930204 into master Oct 22, 2024
49 checks passed
@poiana poiana deleted the fix/use_local_zig_folder branch October 22, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants