-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(driver): add support for mlock2 syscall #358
Conversation
Hi @alacuku. Thanks for your PR. I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alacuku ! Thanks for this PR!
I left a minor comment, but otherwise it LGTM!
Note however that it won't be merged now because we are currently in the release process for Falco 0.32 :) So, bear with us, we will try our best to let it in after Falco 0.32 is out!
590b1cc
to
cd2841f
Compare
Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
cd2841f
to
6524678
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just a minor comment
Signed-off-by: Aldo Lacuku <aldo@lacuku.eu> Co-authored-by: Andrea Terzolo <andrea.terzolo@polito.it>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 00755f0683b6c6796d19cbac7639f536ce6dfb21
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, Andreagit97 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you, Aldo!
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-ebpf
/area libscap
/area libsinsp
What this PR does / why we need it:
This PR adds support for the
mlock2
system call.Which issue(s) this PR fixes:
falcosecurity/falco#1998
Fixes #
Special notes for your reviewer:
The
event_flag
for the sycall has been set toEF_DROP_SIMPLE_CON
.Does this PR introduce a user-facing change?: