Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(driver): add support for mlock2 syscall #358

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented May 25, 2022

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-ebpf

/area libscap

/area libsinsp

/area tests

/area proposals

What this PR does / why we need it:
This PR adds support for the mlock2 system call.

Which issue(s) this PR fixes:
falcosecurity/falco#1998

Fixes #

Special notes for your reviewer:
The event_flag for the sycall has been set to EF_DROP_SIMPLE_CON.

Does this PR introduce a user-facing change?:

update(driver): add support for mlock2 syscall

@poiana
Copy link
Contributor

poiana commented May 25, 2022

Hi @alacuku. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alacuku ! Thanks for this PR!
I left a minor comment, but otherwise it LGTM!
Note however that it won't be merged now because we are currently in the release process for Falco 0.32 :) So, bear with us, we will try our best to let it in after Falco 0.32 is out!

driver/event_table.c Outdated Show resolved Hide resolved
Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
@leogr
Copy link
Member

leogr commented Aug 5, 2022

/ok-to-test

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a minor comment

driver/ppm_flag_helpers.h Outdated Show resolved Hide resolved
Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>

Co-authored-by: Andrea Terzolo <andrea.terzolo@polito.it>
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 5, 2022

LGTM label has been added.

Git tree hash: 00755f0683b6c6796d19cbac7639f536ce6dfb21

@poiana
Copy link
Contributor

poiana commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, Andreagit97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Aug 5, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thank you, Aldo!

@poiana poiana merged commit 24043b6 into falcosecurity:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants