-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(rules): initial tagging of sandbox or incubating rules round1 #111
cleanup(rules): initial tagging of sandbox or incubating rules round1 #111
Conversation
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
@@ -2494,9 +2494,10 @@ | |||
- rule: Unexpected K8s NodePort Connection | |||
desc: Detect attempts to use K8s NodePorts from a container | |||
condition: (inbound_outbound) and fd.sport >= 30000 and fd.sport <= 32767 and container and not nodeport_containers | |||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
condition resolves to and container and not container
, we missed that this can never evaluate to true if not tuned.
Rules files suggestionsfalco_rules.yamlComparing Major changes:
Patch changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM label has been added. Git tree hash: d24bb8e52acbe1f9b6fde858414968698ff710a9
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: incertum, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
What this PR does / why we need it:
Initially tag remaining rules either w/ sandbox or incubating maturity. First pass, will be re-balanced and corrected as needed after each rule has been tagged alongside general improvements to rules conditions, descriptions or output fields consistency changes that will follow.
@LucaGuerra
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: