-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(rules): adjust priority for Run shell untrusted #129
cleanup(rules): adjust priority for Run shell untrusted #129
Conversation
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
@incertum: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Rules files suggestionsfalco_rules.yamlComparing Major changes:
Patch changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed! Especially for out-of-the-box rules we shouldn't have any debug rules.
LGTM
LGTM label has been added. Git tree hash: 707d2ba4856b2223e5bc52e62dbfa50735b703c8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, darryk10, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area rules
Proposed rule maturity level
/area maturity-stable
What this PR does / why we need it:
@darryk10 adjusting priority for "Run shell untrusted". In addition, will propose an update to the https://falco.org/docs/rules/style-guide/ stating no upstream rule shall be of priority debug, so that no adopter needs to run Falco with priority set to debug unless they choose to based on their customizations ...
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: