Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump falcoctl in registry binary to resolve CVE-2022-1996 in indirect dependency github.com/emicklei/go-restful #134

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

tspearconquest
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:
Bumps the falcoctl package in the registry go.mod to resolve CVE-2022-1996 in the indirect dependency github.com/emicklei/go-restful

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

…in indirect dependency github.com/emicklei/go-restful

Signed-off-by: Thomas Spear <tspear@conquestcyber.com>
@poiana
Copy link

poiana commented Aug 20, 2023

Welcome @tspearconquest! It looks like this is your first PR to falcosecurity/rules 🎉

@tspearconquest
Copy link
Contributor Author

I also ran go mod tidy which is why so many lines are removed; looks like a ton of dependencies changed between falcoctl v0.3.0-rc5 and v0.5.1

@incertum
Copy link
Contributor

@LucaGuerra when you are back and @maxgio92

@maxgio92
Copy link
Member

/lgtm

JFI #105 also bumps falcoctl furher

@poiana
Copy link

poiana commented Aug 23, 2023

LGTM label has been added.

Git tree hash: 1b3cc00ea2d3abd2fe14a6e7fbfe8a54b2560377

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum, maxgio92, tspearconquest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit af38849 into falcosecurity:main Aug 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants