-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(rules): comment how to reduce reverse shell detection noise #136
Conversation
The fd.types field introduced in libs 0.12.0 allows us to improve the reverse shell rule so it fires only once all three of stdout/stderr/stdin are redirected. Signed-off-by: Allan Xavier <allan.xavier@sysdig.com>
Welcome @allanembedded! It looks like this is your first PR to falcosecurity/rules 🎉 |
Rules files suggestionsfalco_rules.yamlComparing Major changes:
Patch changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thank you! This is a great first step in guidance and we will continue working on it!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: allanembedded, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 8925438e04476cac6e96d350425be03cc23048cb
|
The fd.types field introduced in libs 0.12.0 allows us to improve the reverse shell rule so it fires only once all three of stdout/stderr/stdin are redirected.
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area rules
Proposed rule maturity level
What this PR does / why we need it:
Informs users of the new
fd.types[]
field and how it can be used to improve the existing reverse shell rule.Which issue(s) this PR fixes:
Fixes #131
Special notes for your reviewer:
Please see discussion in the above issue for more context to the change.