-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(rules): update container_entrypoint (2/n) #137
Conversation
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
@incertum: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Rules files suggestionsfalco_rules.yamlComparing Major changes:
Patch changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM label has been added. Git tree hash: 07d13ea0a1140bf5537c67cf180b711ab025ab2d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@incertum could you post just a lineage example for crio
? In this way, we will remember why we chose to add it. You could use this tool to capture a lineage https://github.com/Andreagit97/bpftree#-lineage or whatever you prefer :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, darryk10, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
oh just saw the lineage here #133 (comment) |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area rules
Proposed rule maturity level
/area maturity-stable
What this PR does / why we need it:
Update container_entrypoint because of new process tree logic to account for new fall backs for cri-o runtime.
@Andreagit97
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: