-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(rules): add "Disallowed SSH Connection Non Standard Port" rule #147
Conversation
Rules files suggestionsfalco_rules.yamlComparing Major changes:
Minor changes:
Patch changes:
|
6954890
to
b0658d4
Compare
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
b0658d4
to
01537b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @incertum ,
the use case looks pretty solid to me and during my tests I haven't seen much noise coming from this rule. Great rule and use case! This might be a good rule to enable by default after the graduation based on the framework!
LGTM label has been added. Git tree hash: 311b518002ff43be1da7ad553b6ed066e27de36f
|
Thanks @darryk10 agreed this one can be bumped to Stable afterwards similarly to how we plan it for the memfd + exec case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, darryk10, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area rules
Proposed rule maturity level
/area maturity-incubating
What this PR does / why we need it:
During the latest audit I noticed a major coverage gap in the upstream rules wrt SSH connections. This rule adds yet another detection to the upstream rules to alert on various types of payloads that can be used in command injection attacks that can lead to RCE.
@loresuso @darryk10 @leogr
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: